Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alarm doesn't persist through resets #1330

Closed
AndreySV opened this issue Sep 14, 2022 · 1 comment · Fixed by #1367
Closed

Alarm doesn't persist through resets #1330

AndreySV opened this issue Sep 14, 2022 · 1 comment · Fixed by #1367
Labels
bug Something isn't working

Comments

@AndreySV
Copy link

AndreySV commented Sep 14, 2022 •
edited
Loading

Description

Sometimes devices reboots (by watchdog or because of low battery), then alarm time and settings are lost. As result alarm is missed and device has to be setup again to be used as wakeup source. This feature would be useful for regular repeatable alarms especially.
@minacode
Copy link
Contributor

I would even label this as a bug.

@ght ght mentioned this issue Sep 14, 2022
Closed
2 tasks
@Riksu9000 Riksu9000 added bug Something isn't working and removed feature request labels Feb 21, 2023
@Riksu9000 Riksu9000 changed the title Save wakeup alarms in non-volatile memory to preserve settings after device reset/watchdog reboot Alarm doesn't persist through resets Feb 22, 2023
@NeroBurner NeroBurner mentioned this issue Sep 19, 2024
Merged
NeroBurner pushed a commit that referenced this issue Sep 21, 2024
@ght @NeroBurner
AlarmController: Add saving alarm time to file
0d41924 
Save the set alarm time to the SPI NOR flash, so it does not reset to
the default value when the watch resets, e.g. due to watchdog timeout
or reflashing of a new version of InfiniTime.

Just like the `Settings.h` `LoadSettingsFromFile()` the previous alarm
at boot (if available) and `SaveSettingsToFile()` the current alarm when
the `Alarm.h` screen is closed (only if the settings have changed).

The alarm-settings file is stored in `.system/alarm.dat`. The `.system`
folder is created if it doesn't yet exist.

Fixes: #1330
NeroBurner pushed a commit that referenced this issue Sep 21, 2024
@ght @NeroBurner
AlarmController: Add saving alarm time to file
ae860cc 
Save the set alarm time to the SPI NOR flash, so it does not reset to
the default value when the watch resets, e.g. due to watchdog timeout
or reflashing of a new version of InfiniTime.

Just like the `Settings.h` `LoadSettingsFromFile()` the previous alarm
at boot (if available) and `SaveSettingsToFile()` the current alarm when
the `Alarm.h` screen is closed (only if the settings have changed).

The alarm-settings file is stored in `.system/alarm.dat`. The `.system`
folder is created if it doesn't yet exist.

Fixes: #1330
NeroBurner pushed a commit that referenced this issue Sep 23, 2024
@ght @NeroBurner
AlarmController: Add saving alarm time to file
7d7d847 
Save the set alarm time to the SPI NOR flash, so it does not reset to
the default value when the watch resets, e.g. due to watchdog timeout
or reflashing of a new version of InfiniTime.

Just like the `Settings.h` `LoadSettingsFromFile()` the previous alarm
at boot (if available) and `SaveSettingsToFile()` the current alarm when
the `Alarm.h` screen is closed (only if the settings have changed).

The alarm-settings file is stored in `.system/alarm.dat`. The `.system`
folder is created if it doesn't yet exist.

Fixes: #1330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@AndreySV @minacode @Riksu9000