PTS: Add setting to display temperature in Fahrenheit #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FintasticMan
added
enhancement
|
Build size and comparison to main:
|
FintasticMan
force-pushed
the
fahrenheit_pts
branch
3 times, most recently
from
539e126
to
f1ef573
Compare
|
@FintasticMan Thanks for this PR! I usually refrain from adding new settings but I think we cannot avoid this one : the world use 2 units to measure the temperature, we need to adapt :-) Would you like to port those changes to the new Simple Weather Service implementation (#1924) ? We'll probably merge it soon. |
|
Yes, I'll rebase this onto #1924 👍 |
FintasticMan
force-pushed
the
fahrenheit_pts
branch
2 times, most recently
from
3f552ce
to
6d3c77a
Compare
JF002
reviewed
Dec 23, 2023
FintasticMan
force-pushed
the
fahrenheit_pts
branch
3 times, most recently
from
2711ce3
to
1b45e1f
Compare
FintasticMan
force-pushed
the
fahrenheit_pts
branch
from
1b45e1f
to
89f0f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "weather format" setting, which can be either Metric or Imperial.
Fixes #1783.
@kieranc does this look good to you?