Fix MotorController::Init call order #2070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
LoadNewScreen
here (and the one below it) callsMotorController::StopRinging()
here, which in turn callsxTimerStop
to stop the ringing timer. However, this timer only gets created whenDisplayApp::InitHw
is called, which currently happens inDisplayApp::Process
after the initial call toLoadNewScreen
. This means thatxTimerStop
is called on uninitialized data, which has undefined behaviour.This PR makes it so that the call to
MotorController::Init
happens beforeLoadNewScreen
.