Merge pull request #2630 from scott-ray-wilson/incorrect-import-value…

…-display-fix Fix: Correct Secret Value Override Display on Overview Table
Infisical · Oct 21, 2024 · 614e493 · 614e493
2 parents 0a38374 + 14e92f8
commit 614e493
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 7 deletions.
diff --git a/frontend/src/hooks/api/secrets/queries.tsx b/frontend/src/hooks/api/secrets/queries.tsx
@@ -48,7 +48,7 @@ export const fetchProjectSecrets = async ({
 };
 
 export const mergePersonalSecrets = (rawSecrets: SecretV3Raw[]) => {
-  const personalSecrets: Record<string, { id: string; value?: string }> = {};
+  const personalSecrets: Record<string, { id: string; value?: string; env: string }> = {};
   const secrets: SecretV3RawSanitized[] = [];
   rawSecrets.forEach((el) => {
     const decryptedSecret: SecretV3RawSanitized = {
@@ -69,17 +69,19 @@ export const mergePersonalSecrets = (rawSecrets: SecretV3Raw[]) => {
     if (el.type === SecretType.Personal) {
       personalSecrets[decryptedSecret.key] = {
         id: el.id,
-        value: el.secretValue
+        value: el.secretValue,
+        env: el.environment
       };
     } else {
       secrets.push(decryptedSecret);
     }
   });
 
   secrets.forEach((sec) => {
-    if (personalSecrets?.[sec.key]) {
-      sec.idOverride = personalSecrets[sec.key].id;
-      sec.valueOverride = personalSecrets[sec.key].value;
+    const personalSecret = personalSecrets?.[sec.key];
+    if (personalSecret && personalSecret.env === sec.env) {
+      sec.idOverride = personalSecret.id;
+      sec.valueOverride = personalSecret.value;
       sec.overrideAction = "modified";
     }
   });

diff --git a/...ws/Org/MembersPage/components/OrgGroupsTab/components/OrgGroupsSection/OrgGroupsTable.tsx b/...ws/Org/MembersPage/components/OrgGroupsTab/components/OrgGroupsSection/OrgGroupsTable.tsx
@@ -335,7 +335,12 @@ export const OrgGroupsTable = ({ handlePopUpOpen }: Props) => {
               })}
           </TBody>
         </Table>
-        {groups?.length === 0 && <EmptyState title="No groups found" icon={faUsers} />}
+        {filteredGroups?.length === 0 && (
+          <EmptyState
+            title={groups?.length === 0 ? "No groups found" : "No groups match search"}
+            icon={faUsers}
+          />
+        )}
       </TableContainer>
     </div>
   );

diff --git a/...Org/MembersPage/components/OrgMembersTab/components/OrgMembersSection/OrgMembersTable.tsx b/...Org/MembersPage/components/OrgMembersTab/components/OrgMembersSection/OrgMembersTable.tsx
@@ -377,7 +377,14 @@ export const OrgMembersTable = ({ handlePopUpOpen, setCompleteInviteLinks }: Pro
           </TBody>
         </Table>
         {!isLoading && filterdUser?.length === 0 && (
-          <EmptyState title="No organization members found" icon={faUsers} />
+          <EmptyState
+            title={
+              members?.length === 0
+                ? "No organization members found"
+                : "No organization members match search"
+            }
+            icon={faUsers}
+          />
         )}
       </TableContainer>
     </div>

diff --git a/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx b/frontend/src/views/SecretOverviewPage/SecretOverviewPage.tsx
@@ -524,6 +524,8 @@ export const SecretOverviewPage = () => {
   );
 
   const allRowsSelectedOnPage = useMemo(() => {
+    if (!secrets?.length && !folders?.length) return { isChecked: false, isIndeterminate: false };
+
     if (
       (!secrets?.length ||
         secrets?.every((secret) => selectedEntries[EntryType.SECRET][secret.key])) &&