Feature: KMS MVP #2497
Merged
Feature: KMS MVP #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-ray-wilson
force-pushed
the
kms-feature
branch
from
6c4e8a9 to
f6d45af
Compare
akhilmhdh
requested changes
Oct 2, 2024
There was a problem hiding this comment.
The base64 part i think we need better explanation. I find it really confusing what it was trying to do.
And i didn't understand that I had to click on decode base64.
Also should we make the encryption and decryption result as a SecretInput component. Because its kinda of sensitive data and should not be shown explicitly as text right? It should be more like a password kinda ux
...c/views/Project/RolePage/components/RolePermissionsSection/ProjectRoleModifySection.utils.ts
Outdated
Show resolved
Hide resolved
scott-ray-wilson
force-pushed
the
kms-feature
branch
from
f93c53e to
cf5c886
Compare
dangtony98
requested changes
Oct 3, 2024
backend/src/db/migrations/20240924172713_add-kms-key-project-id.ts
Outdated
Show resolved
Hide resolved
akhilmhdh
previously requested changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR adds the ability to create and manage KMS keys and perform cryptographic operations with them. The KMS currently only supports symmetric keys for encryption and decryption but additional key types and operations will be added in the future.
kms.mov
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets