Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: audit log migration + special handing #2523

Merged
merged 16 commits into from
Oct 7, 2024
Merged

misc: audit log migration + special handing #2523

merged 16 commits into from
Oct 7, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Oct 2, 2024 •
edited
Loading

This PR does the following:

  • optimizes existing audit log queries
  • developed support for having a completely separate database for audit logs
  • migrated audit logs to a partitioned structure

Description 📣

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@sheensantoscapadngan sheensantoscapadngan changed the title WIP misc: move audit logs to dedicated DB misc: move audit logs to dedicated DB Oct 3, 2024
@sheensantoscapadngan sheensantoscapadngan changed the title misc: move audit logs to dedicated DB misc: audit log migration + special handing Oct 3, 2024
@sheensantoscapadngan sheensantoscapadngan marked this pull request as ready for review October 3, 2024 18:09
maidul98
maidul98 previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just left some questions. Let's test this out together before merge

backend/src/db/migrations/20241003075413_partition-audit-logs.ts Outdated Show resolved Hide resolved
backend/src/db/migrations/20241003075413_partition-audit-logs.ts Outdated Show resolved Hide resolved
backend/src/db/migrations/20241003075413_partition-audit-logs.ts Outdated Show resolved Hide resolved
backend/src/db/migrations/20241003075413_partition-audit-logs.ts Outdated Show resolved Hide resolved
backend/src/ee/services/audit-log/audit-log-dal.ts Show resolved Hide resolved
backend/src/ee/services/audit-log/audit-log-dal.ts Show resolved Hide resolved
backend/src/ee/services/audit-log/audit-log-dal.ts Outdated Show resolved Hide resolved
backend/package.json Outdated Show resolved Hide resolved
maidul98
maidul98 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maidul98 maidul98 merged commit c0fb493 into main Oct 7, 2024
7 checks passed
@sheensantoscapadngan sheensantoscapadngan mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheensantoscapadngan @maidul98