Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Databricks integration #2529

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Databricks integration #2529

merged 9 commits into from
Oct 7, 2024

Conversation

vmatsiiako
Copy link
Collaborator

Description 📣

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

scott-ray-wilson
scott-ray-wilson requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncing worked great once I realized I needed to override the hardcoded DATABRICKS_API_URL - see comments for more details but think we need to be using the workspace URL dynamically from the submitted integration form

frontend/src/pages/integrations/databricks/create.tsx Outdated Show resolved Hide resolved
frontend/src/pages/integrations/databricks/create.tsx Outdated Show resolved Hide resolved
frontend/src/pages/integrations/databricks/create.tsx Outdated Show resolved Hide resolved
backend/src/services/integration-auth/integration-app-list.ts Outdated Show resolved Hide resolved
backend/src/services/integration-auth/integration-app-list.ts Outdated Show resolved Hide resolved
backend/src/services/integration-auth/integration-sync-secret.ts Show resolved Hide resolved
frontend/src/pages/integrations/databricks/authorize.tsx Outdated Show resolved Hide resolved
frontend/src/pages/integrations/databricks/authorize.tsx Outdated Show resolved Hide resolved
frontend/src/pages/integrations/databricks/authorize.tsx Show resolved Hide resolved
frontend/src/pages/integrations/databricks/create.tsx Outdated Show resolved Hide resolved
@maidul98 maidul98 merged commit c30763c into main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHougaard DanielHougaard DanielHougaard left review comments

@scott-ray-wilson scott-ray-wilson scott-ray-wilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmatsiiako @DanielHougaard @scott-ray-wilson @maidul98