Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Default Org Membership Role #2549

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

scott-ray-wilson
Copy link
Contributor

Description 📣

This PR adds the capability to set a default org membership role other than member. The PR also includes code for default project membership roles but is currently commented out as there is no practical application for usage yet.

default-org-membership.mov

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

Copy link
Contributor

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments!

backend/src/services/org/org-role-fns.ts Outdated Show resolved Hide resolved
backend/src/services/org/org-role-fns.ts Show resolved Hide resolved
backend/src/services/org/org-role-fns.ts Outdated Show resolved Hide resolved
backend/src/services/org/org-role-fns.ts Outdated Show resolved Hide resolved
backend/src/services/org/org-role-fns.ts Outdated Show resolved Hide resolved
backend/src/services/org/org-role-service.ts Outdated Show resolved Hide resolved
backend/src/services/org/org-role-fns.ts Outdated Show resolved Hide resolved
@scott-ray-wilson scott-ray-wilson merged commit 75d71d4 into Infisical:main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants