feat: rpm binary #2555
Merged
feat: rpm binary #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
requested review from
sheensantoscapadngan and
scott-ray-wilson
and removed request for
sheensantoscapadngan
DanielHougaard
requested review from
vmatsiiako
and removed request for
scott-ray-wilson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR introduces RPM binary support and fixes frontend.
Overrides in frontend package.json fixes a binary build issue storybookjs/storybook#25075 (comment)
Downgrading slugify version is necessary to make the binary build correctly, because the binary uses commonJS. And slugify >1.1.0 is ESM-only. We also lock the slugify version on the backend.
Type ✨