feat: Process Envkey import in queue #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
force-pushed
the
daniel/envkey-import-bug
branch
from
edc9b90
to
162005d
Compare
akhilmhdh
requested changes
Oct 11, 2024
backend/src/ee/services/secret-snapshot/secret-snapshot-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/external-migration/external-migration-fns.ts
Outdated
Show resolved
Hide resolved
maidul98
changed the title
maidul98
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR implements Redis support for external imports. The reason behind this implementation is to support larger file uploads. Previously if EnvKey imports were larger than 2MB, the request would time-out. The first solution to this was to use
createManySecretsinstead of creating secrets 1-by-1. This wasn't enough for large imports (7MB and above). This Redis implementation allows for any import size. We notify users via. email when 1: the import starts, 2: the import fails or succeeds.Type ✨