fix(vercel-integration): vercel integration initial sync behavior #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
changed the title
maidul98
reviewed
Dec 19, 2024
sheensantoscapadngan
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR addresses #431. Currently the Vercel integration will override all secrets in Vercel once a sync from Infisical happens. This means if you have any existing variables outside of Infisical, they will be removed from your Vercel environment variables. This is dangerous, because it can potentially destroy the entire flow of a user's existing setup.
I've added support for two sync behaviors. Overwrite target, and prefer source. As discussed with @maidul98, adding these two is ideal for the time being.
Type ✨