Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Architecture-Level Resource Estimator Design Document #1027

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Adding Architecture-Level Resource Estimator Design Document #1027

merged 13 commits into from
Aug 16, 2024

Conversation

spencerdearman
Copy link
Contributor

No description provided.

@spencerdearman @vtomole
Update supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md
2203a82 
Co-authored-by: Victory Omole <vtomole2@gmail.com>
@spencerdearman spencerdearman marked this pull request as draft August 14, 2024 16:41
@spencerdearman spencerdearman marked this pull request as ready for review August 14, 2024 19:02
@spencerdearman @vtomole
Update supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md
420caeb 
Co-authored-by: Victory Omole <vtomole2@gmail.com>
@vtomole
Copy link
Member

vtomole commented Aug 15, 2024

A thesis we want to put forward is that architecture-level resource estimations are scattered everywhere and what we are putting forward is one tool that puts all of them together. Before Stim, everybody had to build their own Stim graph from scratch. A few resource estimation papers I could find all roll their own unique architecture-level estimator:

richrines1
richrines1 reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! added a few (non-binding) comments but mostly this looks great

supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md Outdated Show resolved Hide resolved
supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md Outdated Show resolved Hide resolved
supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md Outdated Show resolved Hide resolved
supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md Outdated Show resolved Hide resolved
supermarq-benchmarks/examples/qre-challenge/Lessons-Learned.md Show resolved Hide resolved
vtomole
vtomole approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencerdearman spencerdearman merged commit 1d44a29 into main Aug 16, 2024
19 checks passed
@spencerdearman spencerdearman deleted the qre-estimator branch August 16, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richrines1 richrines1 richrines1 left review comments

@vtomole vtomole vtomole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerdearman @vtomole @richrines1