Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dd-strategies notebook #1038

Merged
merged 17 commits into from
Sep 4, 2024
Merged

update dd-strategies notebook #1038

merged 17 commits into from
Sep 4, 2024

Conversation

richrines1
Copy link
Contributor

@richrines1 richrines1 commented Aug 26, 2024

updates the ibmq-dd-strategies notebook to (1) present our newer dd strategies, (2) target ibm_brisbane instead of perth (which has been retired), and (3) use qiskit-ibm-runtime's local service instead of qiskit-ibm-provider (which has been deprecated). This final change means we no longer require an ibm token for our notebook test

also updates qiskit-superstaq's example-requirements to require qiskit-ibm-runtime instead of qiskit-ibm-provider. the latter is still used in the ibmq-dd notebook, however this is currently excluded from the notebook check and also relies on outdated devices and strategies and so needs to be updated anyway

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@richrines1 richrines1 marked this pull request as draft August 26, 2024 16:10
@richrines1 richrines1 marked this pull request as ready for review August 29, 2024 04:49
@bharat-thotakura bharat-thotakura self-assigned this Aug 29, 2024
Copy link

review-notebook-app bot commented Aug 29, 2024

View / edit / reply to this conversation on ReviewNB

bharat-thotakura commented on 2024-08-29T18:25:49Z
----------------------------------------------------------------

nit: ..., we will be creating a pair...


Copy link

review-notebook-app bot commented Aug 29, 2024

View / edit / reply to this conversation on ReviewNB

bharat-thotakura commented on 2024-08-29T18:25:49Z
----------------------------------------------------------------

This is mainly a style preferential comment so the current default works as well and this can be ignored, but it might make it everso less cramped if we added a cell above that was:

custom_style = {
    'formatter.general.fig_width': 40,
    'formatter.general.fig_unit_height': 1
}
style = qiskit.visualization.timeline.IQXStandard(**custom_style)

and then passed style=style to all the drawers


@richrines1
Copy link
Contributor Author

This is mainly a style preferential comment so the current default works as well and this can be ignored, but it might make it everso less cramped if we added a cell above that was:

oh that's nice, done :)

@richrines1
Copy link
Contributor Author

@bharat-thotakura thanks for the review! i ended up changing the notebook a little further - it occurred to me that there was no reason to include qiskit's transpilation at all, when the purpose of the notebook is just to compare superstaq's different strategies (the other dd notebook is supposed to be the one comparing to qiskit proper)

Copy link
Contributor

@bharat-thotakura bharat-thotakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richrines1 richrines1 merged commit 8b9471b into main Sep 4, 2024
20 checks passed
@richrines1 richrines1 deleted the ibm-dd-strategies-update branch September 4, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants