Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix qcvv progress bars when using cli #1072

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix qcvv progress bars when using cli #1072

merged 1 commit into from
Sep 24, 2024

Conversation

richrines1
Copy link
Contributor

currently some progress bars only work correctly in a notebook environment. this is fixed by importing from tqdm.auto instead of tqdm.notebook

also moves patch_tqdm to qcvv/conftest.py to avoid repetition in each test file

Copy link
Contributor

@cdbf1 cdbf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know tqdm.auto was a thing - this is great thanks!

LGTM

@richrines1 richrines1 merged commit fef8d60 into main Sep 24, 2024
20 checks passed
@richrines1 richrines1 deleted the qcvv-tqdm-cli branch September 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants