Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/user info #1079

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix/user info #1079

merged 4 commits into from
Oct 2, 2024

Conversation

cdbf1
Copy link
Contributor

@cdbf1 cdbf1 commented Oct 1, 2024

Hopefully fixes #1059

I think issue was that something on the server side wasn't happy with using json body for get requests. This PR switches to including get request query in the URL string.

Also updates the route to the correct /user_info

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like def get_user_info doesn't take id as input. Can we handle that in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, just added.

Copy link
Member

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdbf1 cdbf1 merged commit 27d3910 into main Oct 2, 2024
20 checks passed
@cdbf1 cdbf1 deleted the fix/user_info branch October 2, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_user_info() endpoint broken
2 participants