Ability to pass in `options` to `SuperstaqProvider` and `Service` #708

vtomole · 2023-08-22T00:11:21Z

This PR is the beginning of having options be added at the top level. The inspiration for this change is #592.

New way of calling should look like

import json
import os
import qiskit
import qiskit_superstaq as qss


with open(os.path.expanduser('~/.coldquanta/cq_auth.json'), 'r') as file:
    cq_token = json.load(file)

superstaq = qss.superstaq_provider.SuperstaqProvider(token, cq_token=cq_token)

backend = superstaq.get_backend("cq_hilbert_simulator")


qc = qiskit.QuantumCircuit(1, 1)

qc.h(0)
qc.measure(0, 0)

job = backend.run(qc, shots=1)
print(job.result().get_counts())

This PR makes is so that get_job also has acess to the cq_token that's passed in .

Corresponding PR https://github.com/Infleqtion/server-superstaq/pull/2663

vtomole · 2023-08-24T16:40:29Z

@SalahedeenIssa Please test and review.

general-superstaq/general_superstaq/superstaq_client.py

cirq-superstaq/cirq_superstaq/service.py

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

general-superstaq/general_superstaq/superstaq_client.py

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Co-authored-by: Victory Omole <vtomole2@gmail.com>

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

…perstaq into pass_options_to_get

richrines1 · 2023-08-30T23:24:04Z

cirq-superstaq/cirq_superstaq/daily_integration_test.py

@@ -253,6 +253,22 @@ def test_dfe(service: css.Service) -> None:
 assert isinstance(result, float)


+def test_aces(service: css.Service) -> None:


is this part of #699? /should that be merged first to simplify this pr?

I accidentally merged that branch into this one 😭 . Will wait until that one is in before this

…perstaq into pass_options_to_get

richrines1

(few more nits)

general-superstaq/general_superstaq/superstaq_client.py

general-superstaq/general_superstaq/superstaq_client_test.py

richrines1 · 2023-08-31T21:14:04Z

qiskit-superstaq/qiskit_superstaq/superstaq_provider.py

@@ -47,6 +47,7 @@ def __init__(
 api_version: str = gss.API_VERSION,
 max_retry_seconds: int = 3600,
 verbose: bool = False,
+ **kwargs: Any,


should be added to docstring

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

vtomole · 2023-08-31T21:35:23Z

Applied all the suggestions and added docstring. Thanks.

richrines1

lgtm once test is fixed!

general-superstaq/general_superstaq/superstaq_client_test.py

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

epelaaez and others added 8 commits August 15, 2023 14:01

add noise customization to aces

ceb1611

typo

dfd58ae

add support for cirq noise models

ee93c59

move aces to SuperstaqProvider

8d32585

pass optional arguments to json dict iff given

1ce9fb8

Pass options in providers

a63e077

Documentation

b5e6fd2

Remove unneccesary types

281a0c1

vtomole marked this pull request as ready for review August 22, 2023 18:32

vtomole requested review from bharat-thotakura, richrines1 and paaige as code owners August 22, 2023 18:32

vtomole marked this pull request as draft August 22, 2023 21:02

vtomole added 2 commits August 22, 2023 16:19

Park

a516aa2

Kwargs

dc8a56e

vtomole marked this pull request as ready for review August 24, 2023 16:29

Merge branch 'main' into pass_options_to_get

a60cdfa

vtomole requested a review from pgoiporia as a code owner August 24, 2023 16:29

vtomole requested a review from SalahedeenIssa August 24, 2023 16:40

richrines1 reviewed Aug 24, 2023

View reviewed changes

vtomole and others added 4 commits August 25, 2023 14:32

Update general-superstaq/general_superstaq/superstaq_client.py

e7d357a

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Update general-superstaq/general_superstaq/superstaq_client.py

d0ff6d0

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Update general-superstaq/general_superstaq/superstaq_client.py

fdec3cb

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Update cirq-superstaq/cirq_superstaq/service.py

131eb62

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

richrines1 reviewed Aug 25, 2023

View reviewed changes

general-superstaq/general_superstaq/superstaq_client.py Outdated Show resolved Hide resolved

epelaaez and others added 4 commits August 29, 2023 10:32

Merge branch 'main' into aces-noise

d9aa311

reorder methods

a94de3c

reviews

56b13c4

remove extra check

32abf0b

epelaaez and others added 6 commits August 29, 2023 10:43

code review

101768c

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

error prob bullet points

33f2a56

make integration test use cirq noise model

63d4457

Update qiskit-superstaq/qiskit_superstaq/daily_integration_test.py

0d58c9e

Co-authored-by: Victory Omole <vtomole2@gmail.com>

Update general-superstaq/general_superstaq/superstaq_client.py

19ed42e

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Merge branch 'main' into pass_options_to_get

119b362

vtomole requested a review from epelaaez as a code owner August 30, 2023 22:50

vtomole added 2 commits August 30, 2023 17:58

Remove deprecation warnings

8db0f52

Merge branch 'pass_options_to_get' of github.com:Infleqtion/client-su…

6315192

…perstaq into pass_options_to_get

vtomole requested a review from dowusu-antwi as a code owner August 30, 2023 22:58

vtomole requested a review from richrines1 August 30, 2023 23:00

richrines1 reviewed Aug 30, 2023

View reviewed changes

vtomole added 3 commits August 31, 2023 11:30

Merge branch 'main' into pass_options_to_get

32e7f1c

Remove tags in find_jobs

c9def68

Merge branch 'pass_options_to_get' of github.com:Infleqtion/client-su…

56d1b12

…perstaq into pass_options_to_get

vtomole requested a review from richrines1 August 31, 2023 17:07

richrines1 reviewed Aug 31, 2023

View reviewed changes

vtomole and others added 5 commits August 31, 2023 16:30

Update general-superstaq/general_superstaq/superstaq_client.py

ca42929

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Update general-superstaq/general_superstaq/superstaq_client_test.py

803b102

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Update general-superstaq/general_superstaq/superstaq_client_test.py

0a430e4

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Update general-superstaq/general_superstaq/superstaq_client_test.py

7a02190

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

Kwargs docstring

3dce0e5

richrines1 approved these changes Aug 31, 2023

View reviewed changes

general-superstaq/general_superstaq/superstaq_client_test.py Outdated Show resolved Hide resolved

Update general-superstaq/general_superstaq/superstaq_client_test.py

7d8ee98

Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>

vtomole merged commit 3e891cc into main Aug 31, 2023
16 checks passed

vtomole deleted the pass_options_to_get branch August 31, 2023 22:34

vtomole mentioned this pull request Aug 31, 2023

Hilbert jobs inaccessible after cloud token expiration #592

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to pass in `options` to `SuperstaqProvider` and `Service` #708

Ability to pass in `options` to `SuperstaqProvider` and `Service` #708

vtomole commented Aug 22, 2023 •

edited

Loading

vtomole commented Aug 24, 2023

richrines1 Aug 30, 2023 •

edited

Loading

vtomole Aug 31, 2023

richrines1 left a comment

richrines1 Aug 31, 2023

vtomole commented Aug 31, 2023

richrines1 left a comment

		@@ -253,6 +253,22 @@ def test_dfe(service: css.Service) -> None:
		assert isinstance(result, float)


		def test_aces(service: css.Service) -> None:

Ability to pass in options to SuperstaqProvider and Service #708

Ability to pass in options to SuperstaqProvider and Service #708

Conversation

vtomole commented Aug 22, 2023 • edited Loading

vtomole commented Aug 24, 2023

richrines1 Aug 30, 2023 • edited Loading

Choose a reason for hiding this comment

vtomole Aug 31, 2023

Choose a reason for hiding this comment

richrines1 left a comment

Choose a reason for hiding this comment

richrines1 Aug 31, 2023

Choose a reason for hiding this comment

vtomole commented Aug 31, 2023

richrines1 left a comment

Choose a reason for hiding this comment

Ability to pass in `options` to `SuperstaqProvider` and `Service` #708

Ability to pass in `options` to `SuperstaqProvider` and `Service` #708

vtomole commented Aug 22, 2023 •

edited

Loading

richrines1 Aug 30, 2023 •

edited

Loading