Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling pylint's unused-argument flag #982

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Enabling pylint's unused-argument flag #982

merged 11 commits into from
Jul 22, 2024

Conversation

spencerdearman
Copy link
Contributor

  • Updates to include the unused-argument flag in the pyproject.toml file
  • Updates various files that were flagged when running ./pylint_.py --all

Closes #981

@spencerdearman spencerdearman linked an issue Jul 5, 2024 that may be closed by this pull request
Enable pylint's unused-argument flag #981
Closed
vtomole
vtomole requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Now, fix all the unused arguments errors and remove the # pylint: disable=unused-arguments

richrines1
richrines1 reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(a few notes)

cirq-superstaq/cirq_superstaq/ops/qubit_gates.py Outdated Show resolved Hide resolved
cirq-superstaq/cirq_superstaq/ops/qudit_gates.py Outdated Show resolved Hide resolved
qiskit-superstaq/qiskit_superstaq/custom_gates.py Outdated Show resolved Hide resolved
qiskit-superstaq/qiskit_superstaq/serialization.py Outdated Show resolved Hide resolved
qiskit-superstaq/qiskit_superstaq/custom_gates.py Outdated Show resolved Hide resolved
qiskit-superstaq/qiskit_superstaq/superstaq_provider.py Outdated Show resolved Hide resolved
qiskit-superstaq/qiskit_superstaq/custom_gates.py Outdated Show resolved Hide resolved
@spencerdearman
Copy link
Contributor Author

I went through and resolved what @richrines1 suggested. Let me know if there is anything I missed/if you have any other changes that I should make.

@spencerdearman spencerdearman requested review from richrines1 and vtomole and removed request for vtomole July 8, 2024 19:14
richrines1
richrines1 reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some nits

cirq-superstaq/cirq_superstaq/ops/qudit_gates.py Outdated Show resolved Hide resolved
cirq-superstaq/cirq_superstaq/ops/qubit_gates.py Outdated Show resolved Hide resolved
cirq-superstaq/cirq_superstaq/ops/qubit_gates.py Outdated Show resolved Hide resolved
spencerdearman and others added 5 commits July 18, 2024 13:43
@spencerdearman @richrines1
Update cirq-superstaq/cirq_superstaq/ops/qudit_gates.py
a241202 
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
@spencerdearman @richrines1
Update cirq-superstaq/cirq_superstaq/ops/qubit_gates.py
86057af 
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
@spencerdearman @richrines1
Update cirq-superstaq/cirq_superstaq/ops/qubit_gates.py
06245b1 
Co-authored-by: richrines1 <85512171+richrines1@users.noreply.github.com>
@spencerdearman
Fixing files
6468488
@spencerdearman
Merge branch 'main' into unused-argument
7082d24
richrines1
richrines1 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@spencerdearman spencerdearman removed the request for review from vtomole July 18, 2024 21:43
spencerdearman
spencerdearman commented Jul 18, 2024
View reviewed changes
Copy link
Contributor Author

@spencerdearman spencerdearman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed issues

vtomole
vtomole approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencerdearman spencerdearman merged commit f58368f into main Jul 22, 2024
19 checks passed
@spencerdearman spencerdearman deleted the unused-argument branch July 22, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@richrines1 richrines1 richrines1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable pylint's unused-argument flag
3 participants
@spencerdearman @vtomole @richrines1