Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/xeb implementation #993

Merged
merged 37 commits into from
Aug 16, 2024
Merged

Feature/xeb implementation #993

merged 37 commits into from
Aug 16, 2024

Conversation

cdbf1
Copy link
Contributor

@cdbf1 cdbf1 commented Jul 15, 2024

Implement the XEB routine within the QCVV experiment framework.

Blocked by #992

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cdbf1 cdbf1 linked an issue Jul 15, 2024 that may be closed by this pull request
@cdbf1 cdbf1 force-pushed the feature/xeb_implementation branch from 380bfd4 to 47e1c8b Compare July 16, 2024 07:39
@cdbf1 cdbf1 force-pushed the feature/xeb_implementation branch from 47e1c8b to fd3307a Compare July 16, 2024 08:41
@cdbf1 cdbf1 force-pushed the feature/xeb_implementation branch from fd3307a to 7187d83 Compare July 16, 2024 08:53
@cdbf1 cdbf1 force-pushed the feature/xeb_implementation branch from e71d21b to 7cd799c Compare August 5, 2024 10:31
@cdbf1 cdbf1 force-pushed the feature/xeb_implementation branch from e678bc4 to 77e4262 Compare August 5, 2024 14:15
@cdbf1 cdbf1 marked this pull request as ready for review August 14, 2024 07:44
Copy link
Contributor

@dowusu-antwi dowusu-antwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
@@ -0,0 +1,349 @@
{
Copy link
Contributor

@dowusu-antwi dowusu-antwi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"layer" -> "cycle"


Reply via ReviewNB

@@ -0,0 +1,349 @@
{
Copy link
Contributor

@dowusu-antwi dowusu-antwi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"layer" -> "cycle"


Reply via ReviewNB

@@ -0,0 +1,349 @@
{
Copy link
Contributor

@dowusu-antwi dowusu-antwi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"layer" -> "cycle"


Reply via ReviewNB

@@ -0,0 +1,349 @@
{
Copy link
Contributor

@dowusu-antwi dowusu-antwi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    single_qubit_experiment.prepare_experiment(num_circuits=25, cycle_depths=[10, 50, 100, 200])

nit: keyword argument for readability


Reply via ReviewNB

@@ -0,0 +1,349 @@
{
Copy link
Contributor

@dowusu-antwi dowusu-antwi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #9.    print(f"Two qubit depolarising error: {two_qubit_depolarising_error:4f}")

nit: float formatting


Reply via ReviewNB

@@ -0,0 +1,349 @@
{
Copy link
Contributor

@dowusu-antwi dowusu-antwi Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #10.    print(f"Estimated two qubit depolarising error: {two_qubit_depolarising_error_estimate:.4f}")

nit: float formatting


Reply via ReviewNB

@cdbf1 cdbf1 merged commit 3adb01f into main Aug 16, 2024
19 checks passed
@cdbf1 cdbf1 deleted the feature/xeb_implementation branch August 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client-side access to forthcoming XEB routine + Jupyter notebook demo
2 participants