Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github continuous integration workflow #10

Merged
merged 15 commits into from
Jan 12, 2024
Merged

Add github continuous integration workflow #10

merged 15 commits into from
Jan 12, 2024

Conversation

perlinm
Copy link
Collaborator

@perlinm perlinm commented Jan 9, 2024

Based on these continuous integration tests in client-superstaq

@perlinm perlinm self-assigned this Jan 9, 2024
@perlinm
Copy link
Collaborator Author

perlinm commented Jan 9, 2024

Not sure what to do about this failing type check:
image
./checks/mypy_.py passes for me locally (including from a fresh environment)

@vtomole
Copy link
Member

vtomole commented Jan 10, 2024

Which package are you using that has the google dependency in site-packages that mypy is trying to check?

@richrines1
Copy link
Contributor

richrines1 commented Jan 10, 2024

i got the same error. it goes away if you uninstall types-protobuf after running mypy once

it's picking up on this import in cvxpy, which is only relevant to cvxpy[ortools] (and so the package isn't required otherwise): https://github.com/cvxpy/cvxpy/blob/ad6cafb117d24f82e094147e07a5f77a022ad1a8/cvxpy/reductions/solvers/conic_solvers/glop_conif.py#L49

the quick fix is to disable the install_types option for mypy (and add any relevant types- packages to the dev requirements). imo this is a mypy bug though

@richrines1
Copy link
Contributor

apparently this is a known issue python/typeshed#11254

the best solution is probably just to pin

types-protobuf <= 4.24.0.4

for now (and unpin once that issue is resolved)

@perlinm
Copy link
Collaborator Author

perlinm commented Jan 12, 2024

Awesome that worked! Thank you @richrines1!

@perlinm perlinm merged commit 83f50d4 into main Jan 12, 2024
5 checks passed
@perlinm perlinm deleted the github-workflows branch January 12, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants