Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change name of community Flux module #1

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Conversation

wolffcm
Copy link

@wolffcm wolffcm commented Jun 9, 2023

This commit updates this fork of Flux to be separate from the InfluxData-maintained fork, for use and development by interested community members.

I updated the go.mod file and import paths in Go source code to reflect the org name InfluxCommunity, and made a few other changes to generated files, etc so that everything works right. Client code using the InfluxData fork can switch to using this one by importing github.com/InfluxCommunity/flux, but otherwise, everything should be the same.

Of note:

I had to update our special version of pkg-config so that builds would work with both forks.

One outstanding item here is that CI needs to be set up. InfluxData uses Quay to host Docker images and CircleCI for continuous integration. Some other solution will be needed moving forward here.

@lmangani
Copy link
Collaborator

lmangani commented Jun 9, 2023

Awesome @wolffcm! In order to fully test/validate I think we also need a release/tag as well for go mod builders to import the new Flux sources?

@wolffcm wolffcm requested a review from lmangani June 10, 2023 00:23
@wolffcm
Copy link
Author

wolffcm commented Jun 10, 2023

@lmangani How about I merge this, and then we tag it with a version number? We could give it the same version number of the current InfluxData Flux (v0.194.3), or start fresh? I think this could affect you moving forward, so I'll let you decide.

@lmangani
Copy link
Collaborator

@wolffcm sounds like a plan!

@lmangani
Copy link
Collaborator

Note: we'll need issues enabled for this repository. Any chance you could enable it?

@wolffcm wolffcm merged commit be472c0 into master Jun 11, 2023
@wolffcm wolffcm deleted the wolffcm/fork-flux branch June 11, 2023 18:45
@wolffcm
Copy link
Author

wolffcm commented Jun 11, 2023

@lmangani Sure, I've enabled issues.

I think if you tag the latest commit with a version like v0.194.3 you should be able to import it into your projects. I'm curious to see how that goes.

@lmangani
Copy link
Collaborator

Tagged, rebuilt Fluxpipe from this repo, and all is looking good! https://github.com/metrico/fluXpipe/releases/tag/v0.194.6
Will do some more experiments but I'd call this a full success @wolffcm 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants