Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Native Clickhouse driver #3

Merged
merged 9 commits into from
Sep 12, 2023
Merged

feat: Add Native Clickhouse driver #3

merged 9 commits into from
Sep 12, 2023

Conversation

lmangani
Copy link
Collaborator

This PR adds a native Clickhouse binary driver to the Flux SQL stack

Checklist

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🏃 Test cases are included to exercise the new code

@lmangani lmangani marked this pull request as ready for review June 23, 2023 20:36
@lmangani lmangani marked this pull request as draft June 23, 2023 20:37
@lmangani lmangani marked this pull request as ready for review June 23, 2023 20:38
@lmangani lmangani self-assigned this Sep 10, 2023
@akvlad akvlad changed the title Feature: Add Native Clickhouse driver feat: Add Native Clickhouse driver Sep 12, 2023
akvlad
akvlad approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@akvlad akvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passed;
the function works ok

@lmangani lmangani merged commit 8e5b144 into InfluxCommunity:master Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akvlad akvlad akvlad approved these changes

Assignees

@lmangani lmangani

@akvlad akvlad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmangani @akvlad @adubovikov