Add Ruby 3.0 support and replace Travis CI with GitHub Actions #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails like this with rspec-mocks >=3.10.1 because we set logger to
false, and false is frozen.
1) InfluxDB::Logging when logging is disabled does not log
Failure/Error: expect(InfluxDB::Logging.logger).not_to receive(:debug)
ArgumentError:
Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations.
# ./spec/influxdb/logging_spec.rb:42:in `block (3 levels) in <top (required)>'
# ./spec/influxdb/logging_spec.rb:19:in `block (2 levels) in <top (required)>'
Related links
- rspec/rspec-mocks#1357
- https://github.com/rspec/rspec-mocks/blob/v3.10.2/Changelog.md
CI is always set to true in GitHub Actions: https://docs.github.com/en/actions/reference/environment-variables
Pretty standard fixes that were warnings in Ruby 2.7. The only interesting part was in Config spec, I had to split the args array into kwargs manually. Further reading: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
|
I think you need to click some button to enable GitHub Actions for this repo 🤔 You can see that the run, https://github.com/dentarg/influxdb-ruby/actions/runs/535074223, completed successfully in my fork |
dentarg
commented
Feb 3, 2021
| @@ -1,3 +1,7 @@ | |||
| inherit_mode: | |||
| merge: | |||
| - Exclude | |||
There was a problem hiding this comment.
Added this because otherwise rubocop picks up rules from some gem in our cache, background in ruby/setup-ruby#136
You can see example of the failure at https://github.com/dentarg/influxdb-ruby/runs/1825374738?check_suite_focus=true#step:5:9
hennevogel
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #245
Close #246
Close #247 (included in this PR, but didn't work on Ruby < 2.7)