Adopt spec to #248 #250
Merged
Adopt spec to #248 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
force-pushed
the
bugfix/spec-query-quoting
branch
from
63ee836 to
c2a24ed
Compare
|
@ChrisBr just some new quotes in the stubbed requests... |
ChrisBr
reviewed
Feb 6, 2021
| @@ -17,7 +17,7 @@ | |||
| describe "#create_cluster_admin" do | |||
| let(:user) { 'adminadmin' } | |||
| let(:pass) { 'passpass' } | |||
| let(:query) { "CREATE USER #{user} WITH PASSWORD '#{pass}' WITH ALL PRIVILEGES" } | |||
| let(:query) { "CREATE USER \"#{user}\" WITH PASSWORD '#{pass}' WITH ALL PRIVILEGES" } | |||
There was a problem hiding this comment.
Why is pass in single quotes and user in double quotes?
There was a problem hiding this comment.
Because that's what we generate now. See #248
ChrisBr
reviewed
Feb 6, 2021
ChrisBr
approved these changes
Feb 6, 2021
Yeah let's unbreak master first though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.