Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set User-Agent header in gRPC. #101

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat: set User-Agent header in gRPC. #101

merged 2 commits into from
Jul 1, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented May 28, 2024

Proposed Changes

  1. Move setting UserAgent value to AssemblyHelper
  2. Ensure the header is added to Metadata in FlightSqlClient
  3. Add check for user-agent header in tests
  4. Ensure that only 1 user-agent header can be defined per call, and that it is the default from AssemblyHelper

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar May 28, 2024 11:59
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.73%. Comparing base (b437cb0) to head (8065285).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   95.70%   95.73%   +0.02%     
==========================================
  Files          12       12              
  Lines        1072     1079       +7     
  Branches      136      137       +1     
==========================================
+ Hits         1026     1033       +7     
  Misses         11       11              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

LGTM 🚀

@bednar bednar merged commit c5e2d30 into main Jul 1, 2024
11 checks passed
@bednar bednar deleted the feat/userAgent branch July 1, 2024 12:07
@bednar bednar added this to the 0.7.0 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants