Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gzip support #33

Merged
merged 6 commits into from
Jul 26, 2023
Merged

feat: add gzip support #33

merged 6 commits into from
Jul 26, 2023

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 24, 2023 •
edited
Loading

Proposed Changes

  • adds request body gzip compression controlled via payload content length (similarly to already existing support in Go and Javascript clients):
    • threshold and timestamp writing precision are now options in WriteOptions struct nested in InfluxDBClientConfigs - this is breaking API change!
  • enables automatic response decompression

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Merging #33 (292de82) into main (75cc2f7) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        12    +2     
  Lines          736       775   +39     
=========================================
+ Hits           736       775   +39
Files Changed Coverage Δ
Client/Config/InfluxDBClientConfigs.cs 100.00% <100.00%> (ø)
Client/Config/WriteOptions.cs 100.00% <100.00%> (ø)
Client/InfluxDBClient.cs 100.00% <100.00%> (ø)
Client/Internal/GzipHandler.cs 100.00% <100.00%> (ø)

@alespour alespour requested a review from bednar July 24, 2023 14:57
@bednar bednar marked this pull request as ready for review July 25, 2023 08:27
bednar
bednar requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alespour thanks for your PR 👍 There are a few requirements that must be be satisfy before we accept the PR:

Client/Config/WriteOptions.cs Show resolved Hide resolved
@alespour @bednar
fix: add doc string
292de82 
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
bednar
bednar approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@alespour alespour merged commit 360f84c into main Jul 26, 2023
8 checks passed
@alespour alespour deleted the feat/gzip branch July 26, 2023 11:58
@bednar bednar added this to the 0.2.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alespour @bednar