Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: escape tag strings #105

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat: escape tag strings #105

merged 4 commits into from
Sep 25, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Sep 23, 2024

Proposed Changes

Add newline escapes to tag value strings, to be compatible with behavior of earlier client versions.

Also better checks for envars on integration tests.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (ea6f9d2) to head (1eef1a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   85.28%   85.32%   +0.03%     
==========================================
  Files          14       14              
  Lines        1121     1124       +3     
==========================================
+ Hits          956      959       +3     
  Misses        137      137              
  Partials       28       28              
Flag Coverage Δ
85.32% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar requested review from vlastahajek and removed request for bednar September 24, 2024 12:04
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@bednar bednar merged commit 68a0862 into main Sep 25, 2024
11 checks passed
@bednar bednar deleted the feat/escapeTagStrings branch September 25, 2024 09:53
@bednar bednar added this to the 0.11.0 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants