-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom query/gRPC headers #76
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 83.09% 83.38% +0.28%
==========================================
Files 12 12
Lines 994 1011 +17
==========================================
+ Hits 826 843 +17
Misses 138 138
Partials 30 30 ☔ View full report in Codecov by Sentry. |
e824853
to
b0f7542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functional options pattern took a moment to understand, but it's neat. Tests pass locally. Everything else looks OK.
Proposed Changes
ClientConfig
and/or provided to query viaWithHeader
options) to a gRPC query request.go test
) code inexample_query_test.go
, from which documentation examples are generated and linked with functions and types onpkg.go.dev
portal, see fix: use godoc examples instead of code comments #78Checklist