Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InfluxDB Edge/OSS error handling #89

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 3, 2024

Proposed Changes

InfluxDB Edge (OSS) returns slightly different payload when error occurs. This PR extends error handling with support for Edge errors.

Tested with OSS aa28302

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (7d9a001) to head (2ac9dd0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   84.62%   84.71%   +0.08%     
==========================================
  Files          14       14              
  Lines        1106     1112       +6     
==========================================
+ Hits          936      942       +6     
  Misses        140      140              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 3, 2024 08:06
@alespour alespour requested a review from karel-rehor July 4, 2024 08:58
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 👍

LGTM 🚀

@alespour alespour merged commit bdcb577 into main Jul 11, 2024
11 checks passed
@alespour alespour deleted the fix/edge-error-handling branch July 11, 2024 07:13
@bednar bednar added this to the 0.9.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants