Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use build-in Python parsing feature for python >= 3.11 #89

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

bednar
Copy link
Member

@bednar bednar commented May 20, 2024

Proposed Changes

Use build-in date parsing feature. From version 3.11 the performance is same as for ciso8601.

For more info see - influxdata/influxdb-client-python#657

image

https://docs.python.org/3/library/datetime.html#datetime.date.fromisoformat

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.90%. Comparing base (c580008) to head (e14fc84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   50.52%   46.90%   -3.63%     
==========================================
  Files          39       31       -8     
  Lines        2276     2019     -257     
==========================================
- Hits         1150      947     -203     
+ Misses       1126     1072      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review May 20, 2024 11:08
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass for me locally. Everything else looks OK.

@bednar bednar merged commit 18cec22 into main Jun 12, 2024
12 of 13 checks passed
@bednar bednar deleted the datetime-parsing branch June 12, 2024 09:39
@bednar bednar added this to the 0.6.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants