MEM-7622: Stop-salesforce-syncable-objects-from-being-saved-with-sale… #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaig
reviewed
Sep 8, 2025
jhaig
previously approved these changes
Sep 8, 2025
Phillita
reviewed
Sep 8, 2025
Contributor
Phillita
left a comment
Phillita
left a comment
There was a problem hiding this comment.
This seems ok. It looks like for create/update it'll typically add the exception as an error on the object. I'm not sure where the delete errors will go.
Make sure you add a changelog and update the version file
Update CHANGELOG.md version 5.3.0
version.rb 5.3.0
jhaig
approved these changes
Sep 23, 2025
Phillita
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salesforce_ar_sync currently uses Restforce CRUD methods that return false when an error occurs when salesforce saves the object. Change these methods to their bang versions so that we get an error instead of false.