Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search history wrongly saved in search bar #129

Closed
Infocatcher opened this issue Jan 12, 2014 · 1 comment
Closed

Search history wrongly saved in search bar #129

Infocatcher opened this issue Jan 12, 2014 · 1 comment
Labels
bug

Comments

@Infocatcher
Copy link
Owner

Reported here: https://addons.mozilla.org/addon/private-tab/reviews/531528/

view-source:chrome://browser/content/search/search.xml#searchbar

      <method name="doSearch">
        <parameter name="aData"/>
        <parameter name="aWhere"/>
        <body><![CDATA[
          var textBox = this._textbox;

          // Save the current value in the form history
          if (aData && !PrivateBrowsingUtils.isWindowPrivate(window)) {
            ...
          }
@Infocatcher
Copy link
Owner Author

In SeaMonkey:
view-source:chrome://communicator/content/search/search.xml#searchbar

      <field name="usePrivateBrowsing" readonly="true">
        window.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
              .getInterface(Components.interfaces.nsIWebNavigation)
              .QueryInterface(Components.interfaces.nsILoadContext)
              .usePrivateBrowsing
      </field>
      ...
      <method name="doSearch">
        <parameter name="aData"/>
        <parameter name="aWhere"/>
        <body><![CDATA[
          // Save the current value in the form history.
          if (aData && !this.usePrivateBrowsing) {
            ...
          }

Infocatcher added a commit that referenced this issue Jan 12, 2014
@Infocatcher
Override PrivateBrowsingUtils.isWindowPrivate() for search bar
8451ecb 
(for Firefox, part 1 for #129)
Infocatcher added a commit that referenced this issue Jan 12, 2014
@Infocatcher
Override searchbar.usePrivateBrowsing
7afcc8e 
(for SeaMonkey, part 2 for #129)
Infocatcher added a commit that referenced this issue Jan 12, 2014
@Infocatcher
Fix typo in previous commit: correctly check for search.xml in stack
1c43d7d 
(#129)
Infocatcher added a commit that referenced this issue Jan 12, 2014
@Infocatcher
Detect isWindowPrivate() calls from search bar, if installed Tab Mix …
f69fb89 
…Plus

(#129)
Infocatcher added a commit that referenced this issue Jan 13, 2014
@Infocatcher
Remove private data from search bar after private browsing ends
594076f 
Clear undo/redo buffer, if search bar was used at least once from private tab. Also clear value, if last usage was from private tab.
(#129)
Infocatcher added a commit that referenced this issue Jan 13, 2014
@Infocatcher
Update changelog: #129
94090d4
Infocatcher added a commit that referenced this issue Feb 11, 2014
@Infocatcher
Cleanup search bar after closing of last private tab in window
3002ccd 
(#129)
Infocatcher added a commit that referenced this issue Feb 11, 2014
@Infocatcher
Don't handle search bars in private windows
9cd3c97 
(#129)
Infocatcher added a commit that referenced this issue Feb 11, 2014
@Infocatcher
Cleanup search bar after toggleTabPrivate() for last private tab in w…
514ec75 
…indow

(#129)
Infocatcher added a commit that referenced this issue Feb 11, 2014
@Infocatcher
Correct hasPrivateTab(): ignore closing tabs (animations!)
b69ef60 
(related to #129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher