Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API events for toggling using duplication in Firefox 51+ #244

Open
Infocatcher opened this issue Jan 31, 2017 · 1 comment
Open

Update API events for toggling using duplication in Firefox 51+ #244

Infocatcher opened this issue Jan 31, 2017 · 1 comment
Labels
compatibility

Comments

@Infocatcher
Copy link
Owner

See #237.
Now we should provide some way to letting know about this new "toggling".
@Infocatcher
Copy link
Owner Author

https://developer.mozilla.org/en-US/docs/Web/API/Event/Comparison_of_Event_Targets#Event_targets
event.explicitOriginalTarget looks very similar to our case.
So, will dispatch "PrivateTab:PrivateChanged" for new (duplicated) tab and set event.explicitOriginalTarget to original/source tab.

Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Use toggleTabPrivate() for TabRemotenessChange -> fixTabRemoteness()
1430350 
(to check for last private tab and to dispatch PrivateTab:PrivateChanged API event)
(related to #244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Use event.explicitOriginalTarget for link to replaced tab
a8495dd 
(toggling using duplication)
(#244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Also dispatch PrivateChanged, if duplicated tab is in correct state
124727f 
(to notify, that tab was changed)
(#244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Docs for PrivateTab:PrivateChanged -> event.explicitOriginalTarget
d77a3c6 
(#244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Update changelog: API to track toggling using duplication
94feeba 
(#244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Set source tab only for replaceTabAndTogglePrivate()
3bcc349 
(#244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Clear link to source tab after "SSTabRestoring" + small delay
f4b285f 
(#244)
Infocatcher added a commit that referenced this issue Feb 4, 2017
@Infocatcher
Ignore "TabRemotenessChange" after trick to not store closed tab
bba76f6 
(#237, also related to #244)
Infocatcher added a commit to Infocatcher/Link_Properties_Plus that referenced this issue Feb 4, 2017
@Infocatcher
Update for Private Tab 0.2.1.3+, handle toggling using duplication
d74dd04 
See Infocatcher/Private_Tab#244
https://github.com/Infocatcher/Private_Tab#events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher