Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken ability to open new private tab in Firefox 54.0a2+ #252

Closed
30iv opened this issue Mar 10, 2017 · 6 comments
Closed

Broken ability to open new private tab in Firefox 54.0a2+ #252

30iv opened this issue Mar 10, 2017 · 6 comments
Labels
bug compatibility fixed?

Comments

@30iv
Copy link

30iv commented Mar 10, 2017

This is what I got in Browser Console
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsILoadContext.usePrivateBrowsing] bootstrap.js:3764
@Infocatcher
Copy link
Owner

After which action?
Also see #251 (+ #237).

@30iv
Copy link
Author

30iv commented Mar 12, 2017

on clicking button.

@Infocatcher Infocatcher changed the title Broken in Nightly Broken ability to open new private tab in Firefox 54.0a2+ Mar 12, 2017
@Infocatcher
Copy link
Owner

Oh, I see.
As a temporary workaround: browser.newtab.preload = false (in about:config)

Infocatcher added a commit that referenced this issue Apr 8, 2017
@Infocatcher
Hack for browser.newtab.preload = true in Firefox 54+
7ef72ac 
Force override, if PrivateBrowsingUtils.isWindowPrivate() call contains our openNewPrivateTab() in stack
(#252)
@Infocatcher
Copy link
Owner

Test version: private_tab-0.2.1.3pre2-fx-sm.xpi (source code).

@30iv
Copy link
Author

30iv commented Apr 11, 2017

test version fixed the issue.

@Squall-Leonhart
Copy link

im fairly sure this change is incompatible with lazy tab loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility fixed?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Infocatcher @Squall-Leonhart @30iv