Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small images from private tabs (displayed with favicons) are cached to disk #56

Closed
Infocatcher opened this issue May 7, 2013 · 6 comments
Labels

Comments

@Infocatcher
Copy link
Owner

Reported here: https://addons.mozilla.org/addon/private-tab/reviews/462226/
(more than one reason?)

See gBrowser.setIcon():
view-source:chrome://browser/content/tabbrowser.xml

      <method name="setIcon">
              ...
              this.mFaviconService.setAndFetchFaviconForPage(browser.currentURI,
                                                             aURI, false,
                                                             PrivateBrowsingUtils.isWindowPrivate(window) ?
                                                               this.mFaviconService.FAVICON_LOAD_PRIVATE :
                                                               this.mFaviconService.FAVICON_LOAD_NON_PRIVATE);
@Infocatcher
Copy link
Owner Author

And (both from setIcon()):

aTab.setAttribute("image", sizedIconUrl);

and

this._callProgressListeners(browser, "onLinkIconAvailable", [browser.mIconURL]);

=>
resource://app/modules/WindowsPreviewPerTab.jsm
TabWindow.prototype.onLinkIconAvailable()

@galedrag
Copy link

galedrag commented May 8, 2013

Not only the favicons. For example I searched google the word "sunrise" and I can retrieve the next image
5698af1a21225341621a3ca98c1f058c

@Infocatcher
Copy link
Owner Author

and I can retrieve the next image

Oh, forgot about this because I use browser.pagethumbnails.capturing_disabled = true
=> #58

@galedrag
Copy link

galedrag commented May 9, 2013

I did not know that option, thanks

Infocatcher added a commit that referenced this issue May 9, 2013
…entation for icon of image document

Note: doesn't work in SeaMonkey
(workaround for #56)
Infocatcher added a commit that referenced this issue May 9, 2013
we now use this patch for tabs icons
(related to #56)
@Infocatcher
Copy link
Owner Author

Looks fixed for me.
But only in Firefox, see #62.

@galedrag
Copy link

Works for me, thanks

Infocatcher added a commit that referenced this issue Aug 1, 2013
window.ImageDocument isn't available since Firefox 25.0a1 (available only in internal pages: chrome://..., about:...)
(closes #85, related to #56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants