Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed private-protocol URLs reliably crash the browser #94

Closed
Infocatcher opened this issue Aug 24, 2013 · 0 comments
Closed

Malformed private-protocol URLs reliably crash the browser #94

Infocatcher opened this issue Aug 24, 2013 · 0 comments
Labels
bug

Comments

@Infocatcher
Copy link
Owner

Related to #89.
Looks like nsIProtocolHandler.newChannel() should always return some nsIChannel implementation.

Test URIs: private:, private:///google.com.
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Fix nsIProtocolHandler.newChannel() implementation: accept any URI to…
5ee0130 
… avoid crashes

(#94)
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Private protocol: always mark tab as private, even in case of malform…
4913a81 
…ed URI

(related to #94)
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Dispatch "PrivateTab:PrivateChanged" event only if window is really p…
ed5e3cd 
…rivate

(related to #94)
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Private protocol: show error message and usage example in case of wro…
5aa07ac 
…ng URI

(related to #94)
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Private protocol: special error message in case of Services.jsm loadi…
c4036ac 
…ng failure

(related to #94)
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Private protocol: allow open "Usage example" link in current tab
3508180 
(related to #94)
Infocatcher added a commit that referenced this issue Aug 24, 2013
@Infocatcher
Private protocol: display "warning" favicon for malformed URIs
1aa5e77 
(related to #94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Infocatcher