Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Safer AccountManager #1128

Merged
merged 4 commits into from
Mar 4, 2024
Merged

feat: Safer AccountManager #1128

merged 4 commits into from
Mar 4, 2024

Conversation

PhilippeWeidmann
Copy link
Member

First PR for AccountManager improvements. The refactor of AccountManager will be splitted in multiple PRs for improved readability.

This first PRs simply uses the same thread safe types as Mail to access critical properties.

Signed-off-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Signed-off-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Signed-off-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Signed-off-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one remark, I might be overcautious, let me know.

kDriveCore/Data/Cache/AccountManager.swift Show resolved Hide resolved
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilippeWeidmann PhilippeWeidmann merged commit 6148ab3 into master Mar 4, 2024
4 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the safer-accountmanager branch March 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants