Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change a retun type of get_vote_info fromm BoundedVec to Vec #18

Merged
merged 1 commit into from
Apr 3, 2023
Merged

change a retun type of get_vote_info fromm BoundedVec to Vec #18

merged 1 commit into from
Apr 3, 2023

Conversation

energyGiver
Copy link
Contributor

@energyGiver energyGiver commented Apr 3, 2023 •
edited
Loading

Summary

  • change a retun type of get_vote_info fromm BoundedVec to Vec

Describe your changes

  • modify the return type of vote info in pot_pallet, runtime_api and node template
  • remove unused variables and packages

Related Issue

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Well documented code
  • cargo clippy
  • cargo-nightly fmt

@energyGiver energyGiver self-assigned this Apr 3, 2023
@energyGiver energyGiver changed the base branch from master to develop April 3, 2023 02:16
cocoyoon
cocoyoon reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@cocoyoon cocoyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-template 쪽도 변경됏어요?

@energyGiver energyGiver merged commit e400492 into develop Apr 3, 2023
@cocoyoon cocoyoon deleted the feature/8-implement-pot branch May 11, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocoyoon cocoyoon cocoyoon approved these changes

@sweatpotato13 sweatpotato13 Awaiting requested review from sweatpotato13

Assignees

@energyGiver energyGiver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@energyGiver @cocoyoon