Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completed addition and route constants #179

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

EmmanuelObi
Copy link
Member

🛠️ Fixes Issue

Closes issue #178

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for i4g ready!

Name Link
🔨 Latest commit 3d86235
🔍 Latest deploy log https://app.netlify.com/sites/i4g/deploys/63504efb5481780009142d6b
😎 Deploy Preview https://deploy-preview-179--i4g.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for curious-ganache-33d2b4 ready!

Name Link
🔨 Latest commit 3d86235
🔍 Latest deploy log https://app.netlify.com/sites/curious-ganache-33d2b4/deploys/63504efb50d6760009967069
😎 Deploy Preview https://deploy-preview-179--curious-ganache-33d2b4.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ingressive4good
Copy link
Contributor

@EmmanuelObi please fix your merge conflict we need to close this issue

@EmmanuelObi
Copy link
Member Author

@EmmanuelObi please fix your merge conflict we need to close this issue

fixed and updated the PR.

@dprincecoder
Copy link
Contributor

Good to merge

@dprincecoder
Copy link
Contributor

@EmmanuelObi look into this

@EmmanuelObi
Copy link
Member Author

@EmmanuelObi look into this

I've fixed the conflict, again.

@t-bello7
Copy link
Contributor

Kindly fix the merge issue.

@EmmanuelObi
Copy link
Member Author

Kindly fix the merge issue.

I've done this twice already. Please merge in this time, thanks

@EmmanuelObi
Copy link
Member Author

@t-bello7 @dprincecoder @ingressive4good I've fixed arising merge conflicts. Please approve and merge in.

@dprincecoder
Copy link
Contributor

Good to merge

@t-bello7
Copy link
Contributor

👍Good to merge

Copy link
Contributor

@dprincecoder dprincecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @EmmanuelObi other PR has been merged, and app.jsx and routes.jsx are now in conflict with yours, kindly fix it again, so this can be merged

src/Routes.jsx Show resolved Hide resolved
export const NOTIFICATIONS = 'notifications';
export const PROFILE = 'profile';
export const ADMIN = 'admin';
export const USERS = 'users';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you do here good anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants