Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image colors don't match at all (possibly being used as an error color?) #89

Open
interbattles opened this issue Jul 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@interbattles
Copy link

using latest version 2.3.0 built from cargo & aur


just for reference, this is the image im using, the colors i'm getting from matugen don't match at all with the image
(ignore i'm also using custom colors to generate terminal colors)

i tried different color scheme types with varying results (best i could get was with scheme-fruit-salad but its too bright green for me)

the image basically has no blue in it despite being the primary color, pywal can do this correctly but matugen seems to prioritize error color over the primary colors of the image

image


json colors shown:

{
    "colors": {
        "dark": {
            "background": "#121414",
            "color1": "#dcbfc5",
            "color10": "#c3c9b3",
            "color10_container": "#434938",
            "color10_source": "#b9b99b",
            "color10_value": "#b9b99b",
            "color11": "#cec7ac",
            "color11_container": "#4b4732",
            "color11_source": "#c8b692",
            "color11_value": "#c8b692",
            "color12": "#c6c5d6",
            "color12_container": "#454654",
            "color12_source": "#a299b9",
            "color12_value": "#a299b9",
            "color13": "#d0c2d3",
            "color13_container": "#4d4351",
            "color13_source": "#b997b4",
            "color13_value": "#b997b4",
            "color14": "#bbc8d2",
            "color14_container": "#3c4851",
            "color14_source": "#9bb0ca",
            "color14_value": "#9bb0ca",
            "color1_container": "#564146",
            "color1_source": "#d49191",
            "color1_value": "#d49191",
            "color2": "#c3c9b2",
            "color2_container": "#434938",
            "color2_source": "#b6b696",
            "color2_value": "#b6b696",
            "color3": "#cec7ab",
            "color3_container": "#4b4732",
            "color3_source": "#c4b392",
            "color3_value": "#c4b392",
            "color4": "#c6c5d6",
            "color4_container": "#454654",
            "color4_source": "#9e96b6",
            "color4_value": "#9e96b6",
            "color5": "#d0c2d3",
            "color5_container": "#4d4351",
            "color5_source": "#b696b1",
            "color5_value": "#b696b1",
            "color6": "#bcc8d3",
            "color6_container": "#3d4851",
            "color6_source": "#98acc8",
            "color6_value": "#98acc8",
            "color9": "#ddbfc5",
            "color9_container": "#564146",
            "color9_source": "#d89393",
            "color9_value": "#d89393",
            "error": "#ffb4ab",
            "error_container": "#93000a",
            "inverse_on_surface": "#2f3031",
            "inverse_primary": "#516164",
            "inverse_surface": "#e3e2e2",
            "on_background": "#e3e2e2",
            "on_color1": "#3e2b30",
            "on_color10": "#2d3223",
            "on_color10_container": "#dfe5ce",
            "on_color11": "#34311e",
            "on_color11_container": "#eae3c6",
            "on_color12": "#2f2f3d",
            "on_color12_container": "#e2e1f3",
            "on_color13": "#362d3a",
            "on_color13_container": "#eddeef",
            "on_color14": "#26323a",
            "on_color14_container": "#d7e4ef",
            "on_color1_container": "#fadbe1",
            "on_color2": "#2d3222",
            "on_color2_container": "#dfe5cd",
            "on_color3": "#34311d",
            "on_color3_container": "#eae2c6",
            "on_color4": "#2e2f3d",
            "on_color4_container": "#e2e1f3",
            "on_color5": "#362d3a",
            "on_color5_container": "#eddeef",
            "on_color6": "#26323a",
            "on_color6_container": "#d8e4ef",
            "on_color9": "#3e2b30",
            "on_color9_container": "#fadbe1",
            "on_error": "#690005",
            "on_error_container": "#ffdad6",
            "on_primary": "#233336",
            "on_primary_container": "#d4e6e9",
            "on_primary_fixed": "#0e1e21",
            "on_primary_fixed_variant": "#39494c",
            "on_secondary": "#293234",
            "on_secondary_container": "#dbe4e6",
            "on_secondary_fixed": "#141d1f",
            "on_secondary_fixed_variant": "#3f484a",
            "on_surface": "#e3e2e2",
            "on_surface_variant": "#c7c6c6",
            "on_tertiary": "#1c3438",
            "on_tertiary_container": "#cde7ec",
            "on_tertiary_fixed": "#051f23",
            "on_tertiary_fixed_variant": "#334b4f",
            "outline": "#919191",
            "outline_variant": "#464747",
            "primary": "#b8cacd",
            "primary_container": "#39494c",
            "primary_fixed": "#d4e6e9",
            "primary_fixed_dim": "#b8cacd",
            "scrim": "#000000",
            "secondary": "#bfc8ca",
            "secondary_container": "#3f484a",
            "secondary_fixed": "#dbe4e6",
            "secondary_fixed_dim": "#bfc8ca",
            "shadow": "#000000",
            "surface": "#121414",
            "surface_bright": "#383939",
            "surface_container": "#1f2020",
            "surface_container_high": "#292a2a",
            "surface_container_highest": "#343535",
            "surface_container_low": "#1b1c1c",
            "surface_container_lowest": "#0d0e0f",
            "surface_dim": "#121414",
            "surface_variant": "#464747",
            "tertiary": "#b1cbd0",
            "tertiary_container": "#334b4f",
            "tertiary_fixed": "#cde7ec",
            "tertiary_fixed_dim": "#b1cbd0"
        },
        "light": {
            "background": "#faf9f9",
            "color1": "#6f585e",
            "color10": "#5a614e",
            "color10_container": "#dfe5ce",
            "color10_source": "#b9b99b",
            "color10_value": "#b9b99b",
            "color11": "#635f48",
            "color11_container": "#eae3c6",
            "color11_source": "#c8b692",
            "color11_value": "#c8b692",
            "color12": "#5d5d6c",
            "color12_container": "#e2e1f3",
            "color12_source": "#a299b9",
            "color12_value": "#a299b9",
            "color13": "#665b69",
            "color13_container": "#eddeef",
            "color13_source": "#b997b4",
            "color13_value": "#b997b4",
            "color14": "#546069",
            "color14_container": "#d7e4ef",
            "color14_source": "#9bb0ca",
            "color14_value": "#9bb0ca",
            "color1_container": "#fadbe1",
            "color1_source": "#d49191",
            "color1_value": "#d49191",
            "color2": "#5b614e",
            "color2_container": "#dfe5cd",
            "color2_source": "#b6b696",
            "color2_value": "#b6b696",
            "color3": "#645f48",
            "color3_container": "#eae2c6",
            "color3_source": "#c4b392",
            "color3_value": "#c4b392",
            "color4": "#5d5d6c",
            "color4_container": "#e2e1f3",
            "color4_source": "#9e96b6",
            "color4_value": "#9e96b6",
            "color5": "#655b69",
            "color5_container": "#eddeef",
            "color5_source": "#b696b1",
            "color5_value": "#b696b1",
            "color6": "#546069",
            "color6_container": "#d8e4ef",
            "color6_source": "#98acc8",
            "color6_value": "#98acc8",
            "color9": "#6f585d",
            "color9_container": "#fadbe1",
            "color9_source": "#d89393",
            "color9_value": "#d89393",
            "error": "#ba1a1a",
            "error_container": "#ffdad6",
            "inverse_on_surface": "#f2f0f0",
            "inverse_primary": "#b8cacd",
            "inverse_surface": "#2f3031",
            "on_background": "#1b1c1c",
            "on_color1": "#ffffff",
            "on_color10": "#ffffff",
            "on_color10_container": "#181d0f",
            "on_color11": "#ffffff",
            "on_color11_container": "#1f1c0a",
            "on_color12": "#ffffff",
            "on_color12_container": "#1a1b27",
            "on_color13": "#ffffff",
            "on_color13_container": "#211925",
            "on_color14": "#ffffff",
            "on_color14_container": "#111d25",
            "on_color1_container": "#27171b",
            "on_color2": "#ffffff",
            "on_color2_container": "#181d0f",
            "on_color3": "#ffffff",
            "on_color3_container": "#1f1c0a",
            "on_color4": "#ffffff",
            "on_color4_container": "#191b27",
            "on_color5": "#ffffff",
            "on_color5_container": "#211925",
            "on_color6": "#ffffff",
            "on_color6_container": "#111d25",
            "on_color9": "#ffffff",
            "on_color9_container": "#28171b",
            "on_error": "#ffffff",
            "on_error_container": "#410002",
            "on_primary": "#ffffff",
            "on_primary_container": "#0e1e21",
            "on_primary_fixed": "#0e1e21",
            "on_primary_fixed_variant": "#39494c",
            "on_secondary": "#ffffff",
            "on_secondary_container": "#141d1f",
            "on_secondary_fixed": "#141d1f",
            "on_secondary_fixed_variant": "#3f484a",
            "on_surface": "#1b1c1c",
            "on_surface_variant": "#464747",
            "on_tertiary": "#ffffff",
            "on_tertiary_container": "#051f23",
            "on_tertiary_fixed": "#051f23",
            "on_tertiary_fixed_variant": "#334b4f",
            "outline": "#777777",
            "outline_variant": "#c7c6c6",
            "primary": "#516164",
            "primary_container": "#d4e6e9",
            "primary_fixed": "#d4e6e9",
            "primary_fixed_dim": "#b8cacd",
            "scrim": "#000000",
            "secondary": "#576062",
            "secondary_container": "#dbe4e6",
            "secondary_fixed": "#dbe4e6",
            "secondary_fixed_dim": "#bfc8ca",
            "shadow": "#000000",
            "source_color": "#4a5a5d",
            "surface": "#faf9f9",
            "surface_bright": "#faf9f9",
            "surface_container": "#efeded",
            "surface_container_high": "#e9e8e8",
            "surface_container_highest": "#e3e2e2",
            "surface_container_low": "#f5f3f3",
            "surface_container_lowest": "#ffffff",
            "surface_dim": "#dbdada",
            "surface_variant": "#e3e2e2",
            "tertiary": "#4a6267",
            "tertiary_container": "#cde7ec",
            "tertiary_fixed": "#cde7ec",
            "tertiary_fixed_dim": "#b1cbd0"
        }
    }
}

colored image preview (partial):
image

is there any workarounds i can try right now?

@InioX
Copy link
Owner

InioX commented Jul 14, 2024

Hi,

The material colors score function has a thing where it has to return at least one color, if no fitting colors were found it just returns the google blue color as you can see here.

I'll look why no colors are being found later. I don't have much time currently though, so I can't say when.

@interbattles
Copy link
Author

interbattles commented Jul 14, 2024

oh in that case some possibly useful information would be that it's symlinked and has no name extension I don't know if it has to do with formatting

@InioX InioX added the bug Something isn't working label Jul 22, 2024
@interbattles
Copy link
Author

😞 new branch doesnt seem to change anything, debug and verbose logs are normal (opening image.jpg) . fortunately it seems like a one off with just this image though

(*sorry for nagging i rly appreciate ur work 😼)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants