Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete #22

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Autocomplete #22

merged 9 commits into from
Mar 21, 2024

Conversation

AlasDiablo
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@touv touv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this application is an interface, it must not process any data. Our architecture is based on the separation of responsibilities. Column name detection must use dedicated web services (https://openapi.services.istex.fr/?urls.primaryName=data-wrapper%20-%20Conversions%20en%20fichier%20corpus%20compress%C3%A9#/data-wrapper/post-v1-fields-csv).

@AlasDiablo AlasDiablo requested a review from touv March 18, 2024 13:32
@AlasDiablo AlasDiablo marked this pull request as ready for review March 19, 2024 13:48
Copy link
Collaborator

@parmentf parmentf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: ‏Make autocomplete non-blocking

@AlasDiablo AlasDiablo requested a review from parmentf March 21, 2024 08:30
@parmentf parmentf merged commit 6cfc1e8 into main Mar 21, 2024
2 checks passed
@parmentf parmentf deleted the feat/autocomplete branch March 21, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants