Skip to content

Commit

Permalink
fix: rename back TxExtensionOptionI (backport cosmos#16145) (cosmos#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
mergify[bot] authored and kakysha committed Aug 15, 2023
1 parent 24c85bc commit 4f3dcbb
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (server) [#16061](https://github.com/cosmos/cosmos-sdk/pull/16061) Add Comet bootstrap command.
* (x/staking) [#16068](https://github.com/cosmos/cosmos-sdk/pull/16068) Update simulation to allow non-EOA accounts to stake.
* (server) [#16142](https://github.com/cosmos/cosmos-sdk/pull/16142) Remove JSON Indentation from the GRPC to REST gateway's responses. (Saving bandwidth)
* (types) [#16145](https://github.com/cosmos/cosmos-sdk/pull/16145) Rename interface `ExtensionOptionI` back to `TxExtensionOptionI` to avoid breaking change.

### Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion testutil/testdata/codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func RegisterInterfaces(registry types.InterfaceRegistry) {
&HasHasAnimal{},
)
registry.RegisterImplementations(
(*tx.ExtensionOptionI)(nil),
(*tx.TxExtensionOptionI)(nil),
&Cat{},
)

Expand Down
4 changes: 2 additions & 2 deletions types/tx/ext.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import (
)

// TxExtensionOptionI defines the interface for tx extension options
type ExtensionOptionI interface{}
type TxExtensionOptionI interface{} //nolint:revive // to avoid breaking change

// unpackTxExtensionOptionsI unpacks Any's to TxExtensionOptionI's.
func unpackTxExtensionOptionsI(unpacker types.AnyUnpacker, anys []*types.Any) error {
for _, any := range anys {
var opt ExtensionOptionI
var opt TxExtensionOptionI
err := unpacker.UnpackAny(any, &opt)
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion types/tx/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,5 @@ func RegisterInterfaces(registry codectypes.InterfaceRegistry) {
registry.RegisterInterface("cosmos.tx.v1beta1.Tx", (*sdk.Tx)(nil))
registry.RegisterImplementations((*sdk.Tx)(nil), &Tx{})

registry.RegisterInterface("cosmos.tx.v1beta1.TxExtensionOptionI", (*ExtensionOptionI)(nil))
registry.RegisterInterface("cosmos.tx.v1beta1.TxExtensionOptionI", (*TxExtensionOptionI)(nil))
}

0 comments on commit 4f3dcbb

Please sign in to comment.