fix: make PrepareFactory public so chilliass can re-use it #228
Conversation
WalkthroughThe recent changes include making the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- client/chain/chain.go (3 hunks)
Additional comments not posted (2)
client/chain/chain.go (2)
484-488: LGTM! The function is now public.The
PrepareFactoryfunction is now public, and the comment is clear and concise. The code changes are approved.
706-706: LGTM! The usage ofPrepareFactoryis updated.The
PrepareFactoryfunction call is correctly updated to use the publicPrepareFactoryin theSimulateMsgandbuildSignedTxmethods. The code changes are approved.Also applies to: 788-788
|
@kakysha please fix the pre-commit issues before merging the PR |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- chain/exchange/types/spot_orders.go (2 hunks)
- chain/wasmx/types/util.go (1 hunks)
Additional comments not posted (3)
chain/wasmx/types/util.go (1)
17-18: Good addition of the default case.The default case ensures a fallback behavior, improving the control flow.
chain/exchange/types/spot_orders.go (2)
Line range hint
146-166:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
GetBalanceHoldAndMarginDenommatch the new return order.Verification successful
No issues found with the changes.
The function
GetBalanceHoldAndMarginDenomis not called elsewhere in the codebase, so the change in return order does not affect any other part of the code.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `GetBalanceHoldAndMarginDenom` match the new return order. # Test: Search for the function usage. Expect: Only occurances of the new return order. rg --type go -A 5 $'GetBalanceHoldAndMarginDenom'Length of output: 613
Script:
#!/bin/bash # Description: Find all call sites of the function `GetBalanceHoldAndMarginDenom` to verify the new return order. # Test: Search for the function calls. Expect: Occurrences of the function call with the new return order. rg --type go 'GetBalanceHoldAndMarginDenom'Length of output: 193
Script:
#!/bin/bash # Description: Find all call sites of the function `GetBalanceHoldAndMarginDenom` to verify the new return order. # Test: Search for the function calls with more context lines. Expect: Occurrences of the function call with the new return order. rg --type go -A 10 'GetBalanceHoldAndMarginDenom'Length of output: 1052
Script:
#!/bin/bash # Description: Find all call sites of the function `GetBalanceHoldAndMarginDenom` to verify the new return order. # Test: Search for the function calls with more context lines. Expect: Occurrences of the function call with the new return order. rg --type go -A 10 'GetBalanceHoldAndMarginDenom'Length of output: 1052
Line range hint
168-188:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
GetUnfilledMarginHoldAndMarginDenommatch the new return order.
kakysha
merged commit 58aee14
into
feat/update_dependencies_chain_v1_13
Summary by CodeRabbit
Improvements
PrepareFactorymethod in thechainClientstruct public.GetBalanceHoldAndMarginDenomandGetUnfilledMarginHoldAndMarginDenomfunctions forSpotOrderandSpotLimitOrdertypes.Bug Fixes
defaultcase to theIsAllowedfunction to handle unexpected inputs, improving robustness.