Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues once again #139

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Fix some issues once again #139

merged 6 commits into from
Feb 7, 2023

Conversation

w568w
Copy link
Contributor

@w568w w568w commented Feb 4, 2023

This PR will:

  1. fix 首页摘要 代码过长会溢出 #82 ;
  2. fix 作者你好,自带的主题能否实现多种语言的代码高亮 #117 by upgrading highlight.js to the latest version;
    • p.s.: since the library .js file size is too large (~1 MB), it is splitted into an independent bundle.
  3. close Include other files #121 by implementing template function support;
  4. close [bug]标签下的分页功能不可用 #79 , a duplicate of Coding Pages 搭建 标签 不能翻页 /tag%5c写作%5cpage2.html #86 ; close A problem  #106, a dup of Source 下的不同子文件夹内的同名 HTML 可能相互覆盖 #107 .
  5. close 新的使用者 #81 and close 添加使用者 #114 because both websites have been down for a while.

Since the former has been unmaintained for a long time.
This commit is an initial (and toy) implementation for func support. More functions should be ported in the future to make it usable.

This closes InkProject#121 .
@imeoer imeoer self-requested a review February 5, 2023 11:05
funcs.go Show resolved Hide resolved
@imeoer
Copy link
Member

imeoer commented Feb 7, 2023

others LGTM!

@imeoer imeoer merged commit d5584eb into InkProject:master Feb 7, 2023
@imeoer
Copy link
Member

imeoer commented Feb 7, 2023

Hi @w568w, maybe we can publish the release binary using github action automatically, and update the doc.

@w568w w568w mentioned this pull request Feb 7, 2023
@w568w
Copy link
Contributor Author

w568w commented Feb 7, 2023

Hi @w568w, maybe we can publish the release binary using github action automatically, and update the doc.

Good idea. I will resolve that in #140 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants