fix: header item navigation loop

Innei · Jul 28, 2023 · 9e6ea98 · 9e6ea98 · vercel · Jul 28, 2023
1 parent 1076067
commit 9e6ea98
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/components/layout/header/config.ts b/src/components/layout/header/config.ts
@@ -8,7 +8,6 @@ import {
  FaSolidDotCircle,
  FaSolidFeatherAlt,
  FaSolidHistory,
- FaSolidSubway,
  FaSolidUserFriends,
  IcTwotoneSignpost,
  IonBook,
@@ -95,9 +94,9 @@ export const headerMenuConfig: IHeaderMenu[] = [
  },
  ],
  },
- {
- title: '开往',
- icon: h(FaSolidSubway),
- path: 'https://travellings.link',
- },
+ // {
+ //  title: '开往',
+ //  icon: h(FaSolidSubway),
+ //  path: 'https://travellings.link',
+ // },
 ]
diff --git a/src/components/layout/header/internal/HeaderContent.tsx b/src/components/layout/header/internal/HeaderContent.tsx
@@ -190,16 +190,19 @@ function AnimatedItem({
  className?: string
  isActive?: boolean
 }) {
+ const isExternal = href.startsWith('http')
+ const As = isExternal ? 'a' : Link
  return (
  <div>
- <Link
+ <As
  href={href}
  className={clsxm(
  'relative block whitespace-nowrap px-4 py-2 transition',
  isActive ? 'text-accent' : 'hover:text-accent-focus',
  isActive ? 'active' : '',
  className,
  )}
+ target={isExternal ? '_blank' : undefined}
  >
  {children}
  {isActive && (
@@ -211,7 +214,7 @@ function AnimatedItem({
  layoutId="active-nav-item"
  />
  )}
- </Link>
+ </As>
  </div>
  )
 }