Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add footnotes prompt #131

Merged
merged 1 commit into from
Oct 29, 2023
Merged

feat: add footnotes prompt #131

merged 1 commit into from
Oct 29, 2023

Conversation

TNXG
Copy link
Collaborator

@TNXG TNXG commented Oct 28, 2023

Description

✨ feat: add footnotes prompt

Linked Issues

#84

Additional context

add footnotes prompt

@vercel
Copy link

vercel bot commented Oct 28, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Innei on Vercel.

@Innei first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shiro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 0:44am

return (
<Fragment key={state?.key}>
<a
href={`#fn:${content}`}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#fn 这种前缀太 magic 能不能封装一个函数。

<FloatPopover
as="span"
TriggerComponent={footnotes}
type="popover"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type="popover"
type="tooltip"

<p className="flex items-center space-x-1 opacity-80">
<span
className="font-medium"
dangerouslySetInnerHTML={{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要 dangerouslySetInnerHTML

wrapperClassName="footnotes_text"
>
<div className="space-y-2 leading-relaxed">
<p className="flex items-center space-x-1 opacity-80">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像不是很需要

@Innei Innei changed the title ✨ feat: add footnotes prompt feat: add footnotes prompt Oct 29, 2023
@Innei Innei merged commit c50d283 into Innei:main Oct 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants