Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured pattern corrections - Trusted Committer #297

Merged
merged 7 commits into from
Feb 20, 2021
Merged

Structured pattern corrections - Trusted Committer #297

merged 7 commits into from
Feb 20, 2021

Conversation

doronkatz
Copy link
Contributor

Minor corrections and rewording. Additional active/passive voice changes.

@spier spier changed the title Structured pattern corrections Structured pattern corrections - Trusted Committer Feb 19, 2021
@spier spier mentioned this pull request Feb 19, 2021
Closed
spier
spier requested changes Feb 19, 2021
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great contributions!
For the most part I find the new language simpler, and the minor content extensions make sense as well.

I left some feedback for your review.

doronkatz and others added 3 commits February 19, 2021 16:35
@doronkatz @spier
Update patterns/2-structured/trusted-committer.md
26b5ebe 
Co-authored-by: Sebastian Spier <github@spier.hu>
@doronkatz @spier
Update patterns/2-structured/trusted-committer.md
49a6a54 
Co-authored-by: Sebastian Spier <github@spier.hu>
@doronkatz @spier
Update patterns/2-structured/trusted-committer.md
0f69252 
Co-authored-by: Sebastian Spier <github@spier.hu>
@doronkatz doronkatz requested a review from spier February 20, 2021 00:37
@spier spier merged commit a2c20a1 into InnerSourceCommons:master Feb 20, 2021
@spier
Copy link
Member

spier commented Feb 20, 2021

Thanks so much for the contribution @doronkatz!
Your changes are now live in the pattern at https://innersourcecommons.gitbook.io/innersource-patterns/patterns/trusted-committer 🎉

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cewilliams cewilliams Awaiting requested review from cewilliams

@lenucksi lenucksi Awaiting requested review from lenucksi

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid

@spier spier Awaiting requested review from spier

Assignees
No one assigned
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronkatz @spier