Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pattern: Core Team #345

Merged
merged 19 commits into from
Aug 26, 2021
Merged

New Pattern: Core Team #345

merged 19 commits into from
Aug 26, 2021

Conversation

rrrutledge
Copy link
Contributor

Is your InnerSource project difficult for people to work with, yet no one is interested in improving it? Establish a core team to take care of the project's fundamental items so that contributors are enabled to add and use the features that provide value to their scenarios.


View the rendered markdown.

@spier
Copy link
Member

spier commented Aug 18, 2021

Thanks for the PR @rrrutledge.

I added some commits to make fix things discovered by the automated CI checks.

Weill take a deeper look at the content of the pattern in the coming days.

Copy link
Collaborator

@NewMexicoKid NewMexicoKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat pattern, Russ! I think some more details or examples around the level of commitment/resourcing that might be needed for a core team would be helpful.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern looks really interesting already.
Thanks for sharing this @rrrutledge!

My main question is about the preconditions for this pattern, and to some extent how the project got into the state that it is in.

It almost sounds like the project in question doesn't have any team maintaining it, and maybe also no TCs yet? I am not quite sure.

What is surprizing to me about this is that I would suspect that many organizations would subscribe to a statement along the lines of:

Every project in production should have at least 1 team maintaining it.

I might also just misunderstanding something in the current pattern description, I am not quite sure.

@rrrutledge
Copy link
Contributor Author

Thanks, all for the great feedback! I will take a look this week.

Copy link
Contributor Author

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Have a look at the conversations and updates.

Co-authored-by: Sebastian Spier <github@spier.hu>
Copy link
Collaborator

@NewMexicoKid NewMexicoKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, Russ. Thanks.

@spier spier added 📖 Type - Content Work Working on contents is the main focus of this issue / PR 2-structured Patterns with existing instances (Please see our contribution handbook for details) labels Aug 23, 2021
Co-authored-by: Sebastian Spier <github@spier.hu>
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this again, and suggested some changes.

The main discussion is now how and how strongly we should state that the team doesn't have an owner/maintainer before the Solution of this pattern goes into place.

Looks like we are close to resolving this.

Further I have found a couple of spelling issues that I will be committing straight away as they are not controversial.

Copy link
Contributor Author

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this review! Responded to all feedback.

* Many teams need the project.
* Significant tech debt.
* Slow adoption and iteration on the project.
* Nobody is taking reponsibility for the project and contribution ecosystem as a whole.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated this feedback. What do you think?

Comment on lines 55 to 64
* Production bugs.
* Documentation.
* Onboarding tutorials and examples.
* Automated testing.
* CI/CD.
* Local environment.
* Modularization.
* Versioning.
* Monitoring.
* Trailblazing new classes/categories of features.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Problem section the bullets are finishing the sentence that is started before the colon.

Comment on lines 55 to 64
* Production bugs.
* Documentation.
* Onboarding tutorials and examples.
* Automated testing.
* CI/CD.
* Local environment.
* Modularization.
* Versioning.
* Monitoring.
* Trailblazing new classes/categories of features.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them from this list.

rrrutledge and others added 2 commits August 25, 2021 15:59
Co-authored-by: Sebastian Spier <github@spier.hu>
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this new pattern! 🚀

@spier spier merged commit 11decd3 into main Aug 26, 2021
@spier spier deleted the pattern/core-team branch August 26, 2021 09:48
@spier
Copy link
Member

spier commented Aug 26, 2021

The Core Team is now live in our book:
https://patterns.innersourcecommons.org/p/core-team

Congrats and thanks @rrrutledge!

Two questions that I forgot to ask:

  • where in the mindmap would the new pattern fit best? Maybe in Adoption => Organization Challenges?
  • is there any visual that would support this pattern? (using any visuals/pictures/charts in the book makes it a lot prettier but of course we don't want to add a picture just for beauty-sake, it should also support the understandability of the pattern)

Thanks again!

@rrrutledge
Copy link
Contributor Author

🎉 Thank you!

  • I think it could be under Technical Challenges or Organizational Challenges
  • I can't think of any visual that would make things easier to understand. There aren't a lot of relationships to visualize in the pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants