Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of the 'Secure InnerSource' pattern (aka 'Balancing Openness and Security') #384

Merged
merged 52 commits into from
Jan 22, 2022

Conversation

spier
Copy link
Member

@spier spier commented Jan 13, 2022

Initial commit of 'Secure InnerSource' pattern.

Implements #369.

Checklist (for things to do before merging):

  • pick a good name
  • shorten the Patlet
  • add pattern to overview
  • add contributors using Co-authored-by:

After merging:

  • Reach out to Royal Bank of Canada (RBC). Point them to the pattern and ask them, if they would like to extend the pattern with their experience and add themselves to the Known Instances.

GitHub users to add to PR:

bart golsteijn <3263880+bartgolsteijn@users.noreply.github.com>
arlou <arlou.yang@gmail.com>

@spier spier linked an issue Jan 13, 2022 that may be closed by this pull request
Copy link
Member Author

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more info about the areas in the pattern that still need to be worked out.

@@ -0,0 +1,144 @@
# Title

Secure InnerSource
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming things is hard, which is also true for patterns :)

Especially when using the term InnerSource in pattern titles we want to be careful, as otherwise all InnerSource patterns end up with that term in the title.

Some alternative proposals:

  • Security and InnerSource
  • Satisfying Security Concerns
  • Addressing Security Concerns
  • Security Concerns and Mitigation
  • Working with Security
  • Security and Transparency
  • Security and Discoverability
  • Secure Discoverability
  • Discoverability in a Secure Way

Titles are often named either after the problem they address, or the solution they propose.

Anybody got an idea for a great title? Please comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Balancing Openness and Security

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secure Code Sharing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository Sharing Levels

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am opting for the title "Balancing Openness and Security" for now.
Will also add some of the alternative proposals here to the "Alias" section of the pattern.

When we level up the pattern to higher states of maturity, e.g. by getting more orgs to confirm how they are using this pattern, we can reconsider what the best name for this is.

And yes, naming is hard :)


# Known Instances

TBD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be where you put companies that follow this pattern? If so, my previous employer, Verizon, follows this to a T.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conrogers yes exactly. Theoretically you can just add the company the company name here.

However, it becomes more meaningful if we can add a couple of sentences about how the pattern is used at the given org. For example as done here.

Do you still have somebody at Verizon that you would like to pull in here, who can speak to how the pattern is used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Philips. For now without implementation details, these can be added later when certain mechanisms have been implemented and validated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartgolsteijn I added Philips.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conrogers we made some good progress on the review. Therefore we are likely to merge this pattern as an Initial pattern shortly. For patterns in that maturity we don't need Known Instances yet.

If we should merge this PR before you get back to this thread, would you mind opening a new issue, mentioning the opportunity to possibly add Verizon as a Known Instance?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, please go ahead and add Verizon. I was there only a few months ago and know the developer and manager over the innersource effort. I'll ask if Kendra would like to add details but truthfully I can add all the detes myself haha.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Added!

Co-authored-by: Bart Golsteijn <bart.golsteijn@philips.com>
@spier spier changed the title Draft of the 'Secure InnerSource' pattern Draft of the 'Secure InnerSource' pattern (aka 'Balancing Openness and Security') Jan 22, 2022
@spier spier merged commit 9a8a8c7 into main Jan 22, 2022
@spier spier deleted the pattern/secure-innersource branch January 22, 2022 10:42
@spier
Copy link
Member Author

spier commented Jan 22, 2022

Thank you @bartgolsteijn @arlou and @conrogers for your help with this pattern.

I did some final cleanup and the pattern is now available here:
https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/patterns/1-initial/balancing-openness-and-security.md

Last things I changed included:

  • Renaming the pattern to "Balancing Openness and Security"
  • Adding a Sketch/Visual (mostly to remind us to find a better one in the future
  • Adding notes for leveling up the pattern in the future

@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pattern idea: Secure InnerSource
3 participants