-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub InnerSource principles doc contents #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this @zkoppert.
Can you explain why the Engagement Model is key? That part is the only thing that is different from the purpose+principles structure of the other 2 orgs, that's why it caught my eye.
Hey @spier! Any changes you would like to see here? |
My bad. Was looking at this in the GitHub mobile app some time ago and couldn't see the whole file. Then I got distracted. I do recall that I was wondering if it would be easier to follow if we put a generic description of the approach in the Solution block and then put the 3 examples of the company-specific implementations under the Known Instances. Will try to make time for a more detailed review in the evening. But if I don't make it today then I unfortunately won't get to it before next Friday. |
Thanks @spier. Yes I added the implementation details under the known instances header. Let me know what you think, when available, on what we should add for a general description that you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions including some text for the general description. Hope you like it :)
Further I am unsure whether to write the GitHub KI block from the "we" or "they" perspective. Bosch used the latter.
Need to review some other patterns to see if we have a similar example that we can follow.
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
Co-authored-by: Sebastian Spier <github@spier.hu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Added two minor fixes that I will commit myself.
Thank you @zkoppert for sharing the GH principles with us! This will go live in the online book momentarily. |
doing this based off of the discussion here