-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'Communication Tooling' pattern #420
Conversation
I was curious whether the private channels would also include trusted committers? So a subset of the downstream users might have access to the private channels. |
Based on the text it seems like it would. Could also be that a completely different visualization would actually be more helpful :) |
I might put the trusted committers as a second person on the right as they
are usually a small subset of the users and usually are not a part of the
host team (except in a functional/trust sense).
…On Fri, May 27, 2022 at 9:22 AM Sebastian Spier ***@***.***> wrote:
I was curious whether the private channels would also include trusted
committers? So a subset of the downstream users might have access to the
private channels.
Based on the text it seems like it would.
In that case we should add "host team + trusted committers" under the
person on the left in the visual.
I want to make it clear that not all users use all of these channels and
that they way they use them might also differ.
Could also be that a completely different visualization would actually be
more helpful :)
—
Reply to this email directly, view it on GitHub
<#420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARUJ4D2ZKYRCD7ZBGDNJ2LVMDLCHANCNFSM5XAXAIAA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
Tim Yao - ***@***.*** ***@***.***>
***@***.***>
aka NewMexicoKid at National Novel Writing Month, http://nanowrimo.org
<http://www.nanowrimo.org>
co-Municipal Liaison for the Illinois::Naperville region
NaperWriMo - http://naperwrimo.org
|
Right, that is also an option. I did some other fixes and this is the latest version of the visual: |
@MaineC it would be great to get a review from you on this PR, which I think contains some improvements to this pattern. |
One other suggested improvement is to clarify the statement "All communication channels should be documented in the project README.md." in the current pattern. |
Good point @ranton256. I could imagine that we might add a little "mock snippet" of how the description of the communication channels in the README.md could look like. Then people can copy that and adapt it for the needs of their project. |
I was just wondering: Should we call this out in this pattern as well? |
While this PR received some favorable comments, it did not receive a full review yet. I am trying to push the updates to this pattern to our book now, as the pattern was just shared in the March 2023 ISC newsletter, so I am hoping that it might get some more eyeballs than it normally would. @robtuley @yuhattor @NewMexicoKid would one of you be able to review (and possibly approve) this PR, so that we can put this live? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 These all look like good quality improvements to me.
If you're still looking for another which is the remaining un-checked task you can also add "Flutter Entertainment" to the list here. We use Slack a lot, but this pattern closely resembles internal guidance on this topic. I can't share the full page as it has private references but this is a publically safe snippet from the top as an example: |
Thanks for your review @robtuley. Much appreciated. As for adding a known instance: Personally I am curious if Flutter Entertainment uses the same types of channels that are called out in this pattern? Also if you made any other experiences specific to this approach e.g. do you have to explain the communication channels and their purpose only in a single place (your screenshot looks like that), or do teams also add specifics about their use of these channels to their projects? |
While reading the fantastic Communication Tooling pattern I noticed some areas that I could improve.
So I took the opportunity to do this, while also allowing me to ask inline questions about this pattern as part of this PR.
Quick link to the modified pattern:
communication-tooling.md
Key changes