Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'Communication Tooling' pattern #420

Merged
merged 18 commits into from
Mar 9, 2023
Merged

Improve 'Communication Tooling' pattern #420

merged 18 commits into from
Mar 9, 2023

Conversation

spier
Copy link
Member

@spier spier commented May 26, 2022

While reading the fantastic Communication Tooling pattern I noticed some areas that I could improve.

So I took the opportunity to do this, while also allowing me to ask inline questions about this pattern as part of this PR.

Quick link to the modified pattern:
communication-tooling.md

Key changes

  • Changing order of sections according to pattern template
  • Changing the Patlet to a more clear Problem/Solution split.
  • More clearly call out the different types of communication channels.
  • Add links to related patterns
  • Extend section on channeling comms back to the main 3 channels
  • Add a visual. Maybe a picture that describes how a user decides which comms channel to use?
  • Look for another org that can confirm a Known Instance on this (in preparation for leveling this pattern up to "Validated")

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label May 26, 2022
@spier
Copy link
Member Author

spier commented May 26, 2022

I am toying around with a visual to support this pattern. So far I got this:
Communication-Tooling-visual

Another visual idea is to to show requests dropping from the top into some sort of funnel, and then the funnel guides the requests to the correct communication tool. With this I would like to show how the project team (and users) make the decision about which tool/channel to use for what.

I am happy to share the source for this visual above if anybody wants to help.

@NewMexicoKid
Copy link
Collaborator

I am toying around with a visual to support this pattern

I was curious whether the private channels would also include trusted committers? So a subset of the downstream users might have access to the private channels.

@spier
Copy link
Member Author

spier commented May 27, 2022

I was curious whether the private channels would also include trusted committers? So a subset of the downstream users might have access to the private channels.

Based on the text it seems like it would.
In that case we should add "host team + trusted committers" under the person on the left in the visual.
I want to make it clear that not all users use all of these channels and that the way they use them might also differ.

Could also be that a completely different visualization would actually be more helpful :)

@NewMexicoKid
Copy link
Collaborator

NewMexicoKid commented May 27, 2022 via email

@spier
Copy link
Member Author

spier commented Oct 9, 2022

I might put the trusted committers as a second person on the right as they are usually a small subset of the users and usually are not a part of the host team (except in a functional/trust sense).

Right, that is also an option.
However if the TCs have the same access to the Communication channels as the people in the host team, then the visual starts to be confusing.

I did some other fixes and this is the latest version of the visual:

ISC _ Exploring visuals for InnerSource Patterns

@spier
Copy link
Member Author

spier commented Oct 9, 2022

@MaineC it would be great to get a review from you on this PR, which I think contains some improvements to this pattern.
Also note that the visual in the comment thread above has not been included in the pattern yet, as I wanted to see first if people even like it at all.

@spier spier added the 2-structured Patterns with existing instances (Please see our contribution handbook for details) label Oct 9, 2022
@ranton256
Copy link

One other suggested improvement is to clarify the statement "All communication channels should be documented in the project README.md." in the current pattern.
I think giving users some guidance which channels to prefer/when for what types of questions is helpful to collaborators and users when more than one channel is available.

@spier
Copy link
Member Author

spier commented Oct 10, 2022

One other suggested improvement is to clarify the statement "All communication channels should be documented in the project README.md." in the current pattern.
I think giving users some guidance which channels to prefer/when for what types of questions is helpful to collaborators and users when more than one channel is available.

Good point @ranton256.

I could imagine that we might add a little "mock snippet" of how the description of the communication channels in the README.md could look like. Then people can copy that and adapt it for the needs of their project.

@spier
Copy link
Member Author

spier commented Oct 10, 2022

I was just wondering:
Most projects will want to use, or even have to use, the tools that their org already provides. e.g. if the org is using JIRA as an issue tracker, they might have to use that for their project too.

Should we call this out in this pattern as well?
i.e. not surprizing users by the choice of communication channels should be considered a plus in the InnerSource context?

@spier
Copy link
Member Author

spier commented Mar 8, 2023

While this PR received some favorable comments, it did not receive a full review yet.

I am trying to push the updates to this pattern to our book now, as the pattern was just shared in the March 2023 ISC newsletter, so I am hoping that it might get some more eyeballs than it normally would.

@robtuley @yuhattor @NewMexicoKid would one of you be able to review (and possibly approve) this PR, so that we can put this live?

Copy link
Collaborator

@robtuley robtuley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 These all look like good quality improvements to me.

@robtuley
Copy link
Collaborator

robtuley commented Mar 8, 2023

Look for another org that can confirm a Known Instance on this (in preparation for leveling this pattern up to "Validated")

If you're still looking for another which is the remaining un-checked task you can also add "Flutter Entertainment" to the list here. We use Slack a lot, but this pattern closely resembles internal guidance on this topic. I can't share the full page as it has private references but this is a publically safe snippet from the top as an example:

Screenshot 2023-03-08 at 22 43 53

@spier spier merged commit 38d41d3 into main Mar 9, 2023
@spier spier deleted the improve-comms-tooling branch March 9, 2023 07:02
@spier
Copy link
Member Author

spier commented Mar 9, 2023

Thanks for your review @robtuley. Much appreciated.
This is live now at:
https://patterns.innersourcecommons.org/p/communication-tooling

As for adding a known instance:
That would be awesome! Would you mind doing that via a new PR, so that we have a better trace of that activity?

Personally I am curious if Flutter Entertainment uses the same types of channels that are called out in this pattern?

Also if you made any other experiences specific to this approach e.g. do you have to explain the communication channels and their purpose only in a single place (your screenshot looks like that), or do teams also add specifics about their use of these channels to their projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants